From: "Thomas Köhler" <jean-luc@picard.franken.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Problem with ZLS_COLOURS (zsh-3.1.6-test-2)
Date: Wed, 21 Jul 1999 15:13:58 +0200 [thread overview]
Message-ID: <19990721151358.B6054@picard.franken.de> (raw)
In-Reply-To: <199907211001.MAA02739@beta.informatik.hu-berlin.de>; from Sven Wischnowsky on Wed, Jul 21, 1999 at 12:01:34PM +0200
Sven Wischnowsky <wischnow@informatik.hu-berlin.de> wrote:
>
> Thomas Koehler wrote:
>
> > Ah. I think the problem is the first few matches that fit in the "normal
> > file" highlightning. After the first directory name, everything is OK,
> > before, it isn't.
>
> This is the kind of bug I would expect without the second part of
> 7220. Have you tried it?
Uhm, I missed it (hit the delete key too soon in my mailbox?). Here goes
my comment:
Your patch:
| diff -u os/Zle/complist.c Src/Zle/complist.c
| --- os/Zle/complist.c Tue Jul 20 08:54:18 1999
| +++ Src/Zle/complist.c Tue Jul 20 13:01:05 1999
| @@ -159,17 +159,15 @@
| n = ++s;
| while (*s && *s != '=')
| s++;
| - if (!*s )
| + if (!*s)
| return s;
| *s++ = '\0';
| p = getcolval(s);
| - if (*n) {
| - ec = (Extcol) zhalloc(sizeof(*ec));
| - ec->ext = n;
| - ec->col = s;
| - ec->next = c->exts;
| - c->exts = ec;
| - }
| + ec = (Extcol) zhalloc(sizeof(*ec));
| + ec->ext = n;
| + ec->col = s;
| + ec->next = c->exts;
| + c->exts = ec;
This part of the patch causes *ALL* matches to be highlighted in cyan,
even directories. If I don't apply this part but the part down there,
all works as expected.
| if (*p)
| *p++ = '\0';
| return p;
| @@ -460,6 +458,7 @@
| }
| }
| /* Now print the matches. */
| + last_col = COL_NO - 1;
This is the part that makes everything work.
| g = amatches;
| while (g) {
| char **pp = g->ylist;
So, the whole problem is solved by a oneliner. The line
last_col = COL_NO - 1;
was missing.
> Bye
> Sven
Thanks,
Thomas [happy now]
--
Thomas Köhler Email: jean-luc@picard.franken.de
<>< WWW: http://home.pages.de/~jeanluc/
IRC: jeanluc
LCARS --- Linux for Computers on All Real Starships
next prev parent reply other threads:[~1999-07-21 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-21 10:01 Sven Wischnowsky
1999-07-21 13:13 ` Thomas Köhler [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-07-21 12:15 Sven Wischnowsky
1999-07-21 12:00 ` Peter Stephenson
1999-07-21 15:33 ` Thomas Köhler
1999-07-20 8:08 Sven Wischnowsky
1999-07-20 14:49 ` Thomas Köhler
1999-07-19 17:00 Thomas Köhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990721151358.B6054@picard.franken.de \
--to=jean-luc@picard.franken.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).