From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Bug? RE: Un-patch: new pattern matching code
Date: Mon, 9 Aug 1999 10:42:49 +0200 (MET DST) [thread overview]
Message-ID: <199908090842.KAA25290@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Andrej Borsenkow"'s message of Mon, 9 Aug 1999 12:10:14 +0400
Andrej Borsenkow wrote:
> > Anyone who knows any computer science will probably notice that, while it's
> > pretty much a finite state machine, some states are more finite than
> > others. In particularly, backtracking on excluded matches, where in
> > (foo~bar)rod the `bar' only has to match the `foo' and the `rod' is
> > irrelevant, need some extra state recording, and I have retained the old
> > trick that eliminates infinite loops and prevents exponential behaviour
> > when failing to match against things like `(f#o#)#' (the version of perl
> > here goes into an infinite loop when given `(f*o*)*', so it isn't trivial).
> > This has meant leaving holes for pointers in the compiled expression, which
> > ought to work (I've tried to make sure everything is aligned to pointer
> > size anyway) but is probably the most dubious part of the proceedings.
> >
>
> bor@itsrm2:~%> foo=ab12xy
> bor@itsrm2:~%> print ${foo/[[:digit:]]#}
> abxy
> bor@itsrm2:~%> print ${(S)foo/[[:digit:]]#}
> ab12xy
> bor@itsrm2:~%> print ${foo//[[:digit:]]#}
> abxy
> bor@itsrm2:~%> print ${(S)foo//[[:digit:]]#}
> here zsh hangs completely.
It was repeatedly matching the empty string, of course. This makes
that be handled as a special case, stepping one character forward even
if zero characters were matched.
Maybe Peter will have to decide if this is the right thing to do here.
Bye
Sven
P.S.: At least simple things like ${a#*/}, ${a%/*}, ${a##*/}, and
${a%%/*} seem to be circa three times slower than before for me.
--- os/glob.c Mon Aug 9 10:40:41 1999
+++ Src/glob.c Mon Aug 9 10:33:49 1999
@@ -1971,8 +1971,11 @@
*ptr = sav;
}
}
- if (!--n || (n <= 0 && (fl & SUB_GLOBAL)))
+ if (!--n || (n <= 0 && (fl & SUB_GLOBAL))) {
*sp = get_match_ret(*sp, t-s, mpos-s, fl, replstr);
+ if (mpos == start)
+ mpos++;
+ }
if (!(fl & SUB_GLOBAL)) {
if (n) {
/*
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-08-09 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-09 8:42 Sven Wischnowsky [this message]
1999-08-09 17:29 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
1999-08-09 11:33 Sven Wischnowsky
1999-08-06 15:47 Peter Stephenson
1999-08-09 8:10 ` Bug? " Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199908090842.KAA25290@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).