zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: fix for SEGV
Date: Tue, 24 Aug 1999 14:16:18 +0200 (MET DST)	[thread overview]
Message-ID: <199908241216.OAA09744@beta.informatik.hu-berlin.de> (raw)


Try this:

  ...) ./zsh -f
  % setopt autocd; hash wc=/bin/wc; echo|wc

It'll give you a SEGV in `isreallycom()', trying to look at
`cn->u.name' which isn't set because for hashed commands `cn->u.cmd'
is used.

Bye
 Sven

--- os/exec.c	Fri Aug 20 15:18:07 1999
+++ Src/exec.c	Tue Aug 24 14:12:19 1999
@@ -615,12 +615,16 @@
 int
 isreallycom(Cmdnam cn)
 {
-    char fullnam[MAXCMDLEN];
+    if (cn->flags & HASHED)
+	return 1;
+    else {
+	char fullnam[MAXCMDLEN];
 
-    strcpy(fullnam, cn->u.name ? *(cn->u.name) : "");
-    strcat(fullnam, "/");
-    strcat(fullnam, cn->nam);
-    return iscom(fullnam);
+	strcpy(fullnam, cn->u.name ? *(cn->u.name) : "");
+	strcat(fullnam, "/");
+	strcat(fullnam, cn->nam);
+	return iscom(fullnam);
+    }
 }
 
 /**/

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


             reply	other threads:[~1999-08-24 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-08-24 12:16 Sven Wischnowsky [this message]
1999-08-25 15:37 ` Bart Schaefer
1999-08-26  7:16 Sven Wischnowsky
1999-08-27 16:04 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199908241216.OAA09744@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).