6-pws-2

6-pws-2

[Peter Stephenson]

I have probably uploaded
http://www.ifh.de/~pws/computing/zsh-3.1.6-pws-2.tar.gz

- This covers patches to 7551 with exceptions noted

- As I just mentioned, email to here isn't working, use pws@ifh.de if rnsr is
  requid.

- There's an exec.c patch from Tanaka Akira, 7436, left out, because it was
  followed by an inconclusive discussion.  It's supposed to fix exec'ing
  the last element of the last pipeline.  I have not looked at the problem.

- Updates to the completion system may be bungled.  I received some of the
  patches in random order and could have skipped others because there were
  many similar.

- I only deleted Completion/User/_cvs after making 6-pws-2, delete it
  by hand for now.  Let me know of other completion functions which are
  now redundant.

- Personally, I prefer one single completion function for a suite of
  related commands like cvs or pbm, since the accumulated clutter (and
  added time to process completion files the first time) is large.  If it
  stays the way it is I will change the default for function installation
  to keep the subdirectories.

- I haven't looked at the speed of the new pattern matching code.  If case
  statements with *only* simple strings are slower, there's not much I can
  do since it's already optimised to a strcmp(), though I think I can speed
  up the string-building loop in patcompatom().  In other cases I can think
  of a few tweaks.

- If there are any firm suggestions on how pattern matching in ${...},
  particularly substrings, should be changed, please post a summary.

- I still feel the new glob qualifiers for calling code to decide on files
  to include may be overcomplicated.

- Telling me it's time to put together a new development version while I'm
  away may not be a very productive exercise.

- I've moved some files around and corrected a small typo (_arguements) in
  _tar.

- There are lots of things I've probably forgotten; it's taken me most of
  the day just to catch up with the patches.  If you submitted a suggestion
  (rather than a patch) for something like a configuration change then it's
  probably gone in one ear and out the other.

Changes supposedly included:

1999-08-30  Peter Stephenson  <pws@ibmth.df.unipi.it>

	* Tanaka Akira: 7551: Doc/Zsh/expn.yo: mismatched parenthesis.

	* Sven: 7549: Src/hist.c: shell wouldn't exit if writing history
	  file failed.

	* Sven: 7548: Completion/User/_xargs: new.

	* Sven: 7541: Completion/Base/_arguments: fix.

	* Sven: 7540: Src/subst.c, Doc/Zsh/expn.yo: ${name^pat^then^else}
	  tests string and substitutes appropriately.

	* Sven: 7539: Src/subst.c, Doc/Zsh/expn.yo: % parameter flag does
	  prompt escapes.

	* Sven: 7538: Completion/Base/_arguments: completion of trailing
	  non-option arguments.

	* Sven: 7535: Src/glob.c: don't restore badcshglob.

	* Sven: 7533: Completion/Rpm/*, Completion/Base/_arguments,
	  Completion/User/_a2ps, Completion/User/_configure,
	  Completion/User/_dvi, Completion/User/_gdb, Completion/User/_gs,
	  Completion/User/_gs_name, Completion/User/_patch,
	  Completion/User/_pspdf, Completion/User/_tar,
	  Completion/User/_use_lo, Completion/User/_xfig,
	  Completion/User/_xsetroot, Completion/User/_xterm,
	  Completion/X/_gv, Completion/X/_xdvi,
	  Completion/X/_xt_arguments, Completion/X/_xv,
	  Doc/Zsh/compsys.yo: argument handling; new rpm functions.

	* Sven: 7532: Src/Zle/zle_tricky.c: completion bug.

	* Bart, Sven: 7529, 7530: process groups not continued properly.

	* Bart: 7527: KSH_ARRAYS messed up assignment to a
	  hash, plus 7521 typo.

	* Bart: 7521: Src/init.c: replace 7472 and 7490 with thing that
	  tests if hashed command is really there.

	* Sven: 7517: Completion/Base/_arguments,
	  Completion/Pbmplus/_pbmtext, Completion/Pbmplus/_pbmtopk,
	  Completion/Pbmplus/_pktopbm, Completion/Pbmplus/_pnmcomp,
	  Completion/Pbmplus/_pnmtoddif, Completion/Pbmplus/_psidtopgm,
	  Completion/Pbmplus/_pstopnm, Completion/User/_gdb,
	  Completion/User/_gprof, Completion/User/_x_options,
	  Completion/User/_xfig, Completion/User/_xsetroot,
	  Completion/X/_x_borderwidth, Completion/X/_x_geometry,
	  Completion/X/_x_locale, Completion/X/_x_name,
	  Completion/X/_x_resource, Completion/X/_x_selection_timeout,
	  Completion/X/_x_title, Completion/X/_xv: use _arguments more.

	* Tanaka Akira: 7516: Completion/Base/_arguments,
	  Completion/Cvs/_cvs, Completion/Cvs/_cvs_command: fixes.

	* Sven: 7515: Doc/Zsh/compsys.yo, Completion/Base/_arguments,
	  Completion/Pbmplus/_pnmtotiff, Completion/Pbmplus/_ppmtomitsu,
	  Completion/User/_find: _arguments allows descriptions in list of
	  possibilities.

	* Sven: 7514: Src/glob.c, Doc/Zsh/expn.yo: use REPLY to set
	  filename.

	* Bart: 7510: Src/init.c: zsh -ce interprets e as option, not
	  command.

	* Sven: 7512: Completion/Base/_arguments: complete function.

	* Sven: 7500: Completion/Base/_arguments,
	  Completion/Cvs/_cvs_command, Completion/User/_find:
	  word-splitting in _arguments.

	* Tanaka Akira: 7495: Completion/Cvs/_cvs*: new cvs functions.

	* Sven: 7496: Src/glob.c, Src/zsh.h, Doc/Zsh/expn.yo: glob
	  qualifier e:string: with $_ set to filename.

	* Sven: 7492: Completion/Base/_arguments, Completion/User/_find,
	  Completion/X/_x_font: speed up _arguments.

	* Sven: 7490: Src/exec.c: change 7472 not to try test on hashed
	  command.

	* Sven: zsh-users/2511: Src/Zle/zle_tricky.c: bad (old) completion
	  after `$(<'.

	* Sven: 7482: Src/exec.c, Src/glob.c, Src/zsh.h, Doc/Zsh/expn.yo:
	  F:func: glob qualifier calls func to determine whether to
	  include file.

	* Sven: 7480: Src/Zle/zle_tricky.c, Completion/Core/_multi_parts,
	  Completion/User/_xterm, Completion/X/_x_font,
	  Completion/X/_xt_arguments: matching bug.

	* Sven: 7478: Doc/Zsh/compsys.yo, Completion/Base/_arguments,
	  Completion/Builtins/_vars_eq: handling of :: in _arguments.

	* Tanaka Akira: 7477: Completion/User/_xterm,
	  Completion/X/_x_borderwidth, Completion/X/_x_font,
	  Completion/X/_x_geometry, Completion/X/_x_locale,
	  Completion/X/_x_name, Completion/X/_x_resource,
	  Completion/X/_x_selection_timeout, Completion/X/_x_title,
	  Completion/X/_xt_arguments, Completion/X/_xt_session_id:
	  use standard XToolkit arguments.

	* Sven: 7472: Src/exec.c: crash in isreallycom().

	* Sven: 7469: Completion/Base/_arguments,
	  Completion/Base/_command_names, Completion/Builtins/_zftp,
	  Completion/Core/_complete, Completion/Core/_main_complete,
	  Completion/Core/_normal, Completion/User/_x_display,
	  Completion/User/_x_options, Completion/User/_xterm: fix
	  word-splitting for _arguments.

	* Sven: zsh-users/2505: parameter with non-empty prefix.

	* Tanaka Akira: 7468: Completion/User/_xterm: xterm argument
	  completion.

	* Sven: zsh-users/2502: completing '=$' erased word.

	* Sven: 7467: Doc/Zsh/compsys.yo, Completion/Base/_arguments,
	  Completion/Base/_long_options: allow an _arguments option to
	  swallow everything to end of line.

	* Sven: 7465: Src/params.c: reverse indexing of associative
	  arrays.

	* Sven: 7463: Src/Zle/compctl.c, Doc/Zsh/compsys.yo,
	  Completion/Base/_arguments, Completion/Base/_brace_parameter,
	  Completion/Base/_condition, Completion/Base/_long_options,
	  Completion/Base/_math, Completion/Base/_parameter,
	  Completion/Base/_tilde, Completion/Base/_vars,
	  Completion/Builtins/_vars_eq, Completion/Builtins/_zftp,
	  Completion/Commands/_correct_filename,
	  Completion/Commands/_correct_word,
	  Completion/Commands/_expand_word,
	  Completion/Commands/_history_complete_word,
	  Completion/Commands/_most_recent_file,
	  Completion/Commands/_read_comp, Completion/Core/_parameters,
	  Completion/Core/compinit, Completion/User/_chown,
	  Completion/User/_dir_list, Completion/User/_exec_funcs,
	  Completion/User/_find, Completion/User/_gprof,
	  Completion/User/_rlogin, Completion/User/_su,
	  Completion/User/_tar, Completion/User/_users,
	  Util/completion-style-guide: miscellaneous completion fixes.

	* Tanaka Akira: 7460. 7461: Completion/Base/_arguments,
	  Completion/User/_patch: _arguments -s handling with --.

	* Clint Adams: 7459: Config/funcinst.mk, Config/installfns.sh,
	  Doc/Makefile.in, Src/Makefile.in, Src/Makemod.in.in: can set
	  DESTDIR to specify install prefix.

	* Tanaka Akira: 7458: Completion/Base/_arguments,
	  Completion/Base/_long_options, Completion/User/_patch:
	  _patch function and required fixes.

	* Sven: 7457: Doc/Zsh/compsys.yo, Completion/Base/_arguments:
	  handle short options.

	* Sven: 7455: Src/Zle/complist.c: handle lengths of capabilities.

	* Sven: 7454: Doc/Zsh/compsys.yo, Completion/Base/_arguments,
	  Completion/Core/_message: option prefix configuration.

	* Sven: 7429: _pbm: more stuff

	* Tanaka Akira: 7451: Completion/Core/_message,
	  Completion/Pbmplus/_pbmtoepsi, Completion/Pbmplus/_pktopbm,
	  Completion/Pbmplus/_yuvtoppm, Doc/Zsh/compsys.yo: some small
	  mistakes.

	* Sven: 7441: Src/Zle/zle_tricky.c: matching control bug.

	* Sven: 7450: Completion/Base/_arguments,
	  Completion/Base/_long_options, Completion/Base/_subscript,
	  Completion/Builtins/_zmodload, Completion/User/_colors,
	  Completion/User/_cvs, Completion/User/_gdb: explanations and
	  arguments.

	* Tanaka Akira: 7431: Completion/User/_colors: null glob.

	* Tanaka Akira: 7432: Completion/User/_cvs: update.

	* Sven: 7449: Src/module.c, Src/params.c: better errors for failed
	  autoloading; 

	* Sven: 7448: too many files under Completion to list, including
	  new Pbmplus directory: revised pbm completion; pattern completion
	  only if no specific completion; descriptions for completions;
	  better handling for command line arguments.

	* Tanaka Akira: 7417: Completion/User/_pdf, Completion/User/_ps,
	  Completion/User/_pspdf: more programs that take ps or pdf files.

	* Sven: 7430: matching control bug: Src/Zle/zle_tricky.c,
	  Completion/User/_colors, Completion/User/_cursors,
	  Completion/User/_x_options, Completion/User/_xsetroot:
	  bug in matching control.

	* Tanaka Akira: 7428: Completion/User/_pbm,
	  Completion/User/_colors: fix some problems.

	* Sven: 7420: Src/Zle/zle_tricky.c, Doc/Zsh/compsys.yo,
	  Completion/Base/_first, Completion/Builtins/_zftp,
	  Completion/Core/_complete, Completion/Core/_main_complete,
	  Completion/Core/_normal, Completion/User/_colors,
	  Completion/User/_pbm, Completion/User/_x_options: _compskip
	  extended to allow choice of what to skip.

	* Sven: 7418: Completion/User/_pbm: new

	* Sven: 7446: print -P %s didn't work.

	* Bart: 7410: parameter flags doc for M.

	* Sven: 7404: Src/glob.c: repeatedly matching empty string
	  (somehow).

1999-08-06  Peter Stephenson  <pws@ibmth.df.unipi.it>

	* pws: Config/version.mk: 3.1.6-pws-1 made available.

	* Sven: 7386: Src/subst.c: Order of q and Q parameter flags matters.

1999-08-05  Peter Stephenson  <pws@ibmth.df.unipi.it>

	* Sven: 7380: Src/hist.c, Src/subst.c, Doc/Zsh/expn.yo: flag X for
	  reporting errors de-quoting.

	* Sven: 7374: Src/subst.c, Doc/Zsh/expn.yo: modifier to remove one
	  level of quotation, corresponding flags.

	* Sven: 7373: Src/Zle/comp.h, Src/Zle/zle_tricky.c,
	  Completion/Base/_brace_parameter:  support nested parameter
	  expansion type of deal.

1999-08-04  Peter Stephenson  <pws@ibmth.df.unipi.it>

	* Sven: 7355: Src/Zle/compctl.c, Src/Zle/zle_tricky.c: make
	  compadd quoting consistent with compgen.	

1999-08-02  Peter Stephenson  <pws@ibmth.df.unipi.it>

	* Sven: 7349: Src/loop.c, Src/signals.c:  restore errflags in
	  select after a zleread; fix problem restoring function-style trap
	  after a function set it to something else.

	* Sven: 7348: Completion/Core/_path_files, Doc/Zsh/compsys.yo:
	  remove path_keepdir configuration key but don't do keepdir
	  trick unless _files had no type arguments.

	* Sven: 7345, 7346, 7347: Src/Zle/zle_tricky.c: match control
	  problems.

	* Sven: 7344, 7353: Src/cond.c, Src/Modules/example.c,
	  Src/Zle/compctl.c, Util/zsh-development-guide:  conditions can
	  get the tokenized string; better quoting behaviour in
	  IPREFIX/ISUFFIX.

	* Sven: 7343: Src/Zle/zle_tricky.c: quote path prefix and suffix
	  earlier.

	* pws: 7342: Doc/Makfile.in: use makeinfo ... || exit 0 to
	  ignore result of makeinfo.

	* Irving Wolfe: 7336: utils.c: same fcntl() change.

	* Geoff: 7335: init.c: third argument for fcntl().

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: 6-pws-2

[Bart Schaefer]

On Aug 30,  6:00pm, Peter Stephenson wrote:
> Subject: 6-pws-2
> I have probably uploaded
> http://www.ifh.de/~pws/computing/zsh-3.1.6-pws-2.tar.gz
> 
> - This covers patches to 7551 with exceptions noted

Wow, good job, Peter!  The only ones you seem to have missed are:

7414, fix info doc for makeinfo 3.12f
7436, change the way the last command in a pipeline is exec'd

Unless of course I missed the same ones you did, which is possible.  Truth
to tell, I "missed" 7436 on purpose and was watching for whether you would
include it -- did you intentionally leave it out?

There does appear to be one other problem -- there is a complete copy of
each of two versions of the _xterm completer in Completion/X/_xterm.  I
think the top one is the one to keep.

Re: 6-pws-2

[Tanaka Akira]

In article <9908301600.AA12634@ibmth.df.unipi.it>,
  Peter Stephenson <pws@ibmth.df.unipi.it> writes:

> - There's an exec.c patch from Tanaka Akira, 7436, left out, because it was
>   followed by an inconclusive discussion.  It's supposed to fix exec'ing
>   the last element of the last pipeline.  I have not looked at the problem.

I think 7436 is the correct fix to the problem.

> - I only deleted Completion/User/_cvs after making 6-pws-2, delete it
>   by hand for now.  Let me know of other completion functions which are
>   now redundant.

Base/_complete_opts should be removed. Because there are no completion
function which use it (except old _cvs) and it has very poor
name/implementation/document.

> - Personally, I prefer one single completion function for a suite of
>   related commands like cvs or pbm, since the accumulated clutter (and
>   added time to process completion files the first time) is large.  If it
>   stays the way it is I will change the default for function installation
>   to keep the subdirectories.

The separation is sometimes useful for custumizations because we can
override each function individually. These functions behaves like `hook'.
I think it is useful that making hooks more easily without adding new files.
-- 
Tanaka Akira

Modules - How to write ?

[jarausch]

I am curious how to write a module for zsh.
Given that I find the example module cryptic, is there anything that
helps understanding what and why or is the single source the module
loader within ZSH?

Thanks for any hints,
Helmut.



-- 
Helmut Jarausch
Lehrstuhl fuer Numerische Mathematik
Institute of Technology, RWTH Aachen
D 52056 Aachen, Germany

Re: 6-pws-2

[Ollivier Robert]

According to Peter Stephenson:
> - Personally, I prefer one single completion function for a suite of
>   related commands like cvs or pbm, since the accumulated clutter (and
>   added time to process completion files the first time) is large.  If it

I do heartily agree to that, I'd hate to see zsh going into the path of
"let's read a zillion files on startup", first experienced by Perl and its
module syndrom...
-- 
Ollivier ROBERT -=- Eurocontrol EEC/TEC -=- roberto@eurocontrol.fr
The Postman hits! The Postman hits! You have new mail.

Re: 6-pws-2

[Peter Stephenson]

"Bart Schaefer" wrote:
> Wow, good job, Peter!  The only ones you seem to have missed are:
> 
> 7414, fix info doc for makeinfo 3.12f

I didn't get that for some reason (or deleted it without applying it).

> 7436, change the way the last command in a pipeline is exec'd
> 
> Unless of course I missed the same ones you did, which is possible.  Truth
> to tell, I "missed" 7436 on purpose and was watching for whether you would
> include it -- did you intentionally leave it out?

See below.

> There does appear to be one other problem -- there is a complete copy of
> each of two versions of the _xterm completer in Completion/X/_xterm.  I
> think the top one is the one to keep.

This was fixed by Sven's patch, too.

Tanaka Akira wrote:
> > - There's an exec.c patch from Tanaka Akira, 7436, left out, because it was
> >   followed by an inconclusive discussion.  It's supposed to fix exec'ing
> >   the last element of the last pipeline.  I have not looked at the problem.
> 
> I think 7436 is the correct fix to the problem.

I finally looked at it and it seems fine.  I don't understand why it wasn't
working that way before.  Probably it was overlooked in some other changed.

> > - Personally, I prefer one single completion function for a suite of
> >   related commands
> 
> The separation is sometimes useful for custumizations because we can
> override each function individually. These functions behaves like `hook'.
> I think it is useful that making hooks more easily without adding new files.

This is a good point, maybe Sven's idea can help with this.  It would be
nice to keep it as function-based as possible.  Simplifying the initial
implementation (where you could define variables as well as functions) was
a big step to making the whole thing more usable.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: Modules - How to write ?

[Sven Wischnowsky]

jarausch@igpm.rwth-aachen.de wrote:

> I am curious how to write a module for zsh.
> Given that I find the example module cryptic, is there anything that
> helps understanding what and why or is the single source the module
> loader within ZSH?

There is quite a bit in `Etc/zsh-development-guide'. But that is
probably cryptic, too.

Bye
 Sven

P.S.: Hey, they are moved to `Etc'. Great. Thanks, Peter.

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de