From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: new parameter flag?
Date: Tue, 31 Aug 1999 14:43:30 +0200 (MET DST) [thread overview]
Message-ID: <199908311243.OAA29911@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Zefram's message of Tue, 31 Aug 1999 13:25:56 +0100 (BST)
Zefram wrote:
> Sven Wischnowsky wrote:
> >+ opts[PROMPTPERCENT] = 1;
> >+ if (presc < 2)
> >+ opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
>
> No, that's nasty. I can see a need for % expansion, and I can see
> a need for prompt expansion, but prompt expansion with % sequences
> unconditionally enabled? If the user wants something so obscure, they
> can twiddle the options themselves. Make the above
>
> if (presc < 2) {
> opts[PROMPTPERCENT] = 1;
> opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
> }
Hm, yes, I was lead to this mainly by the `name' of the flag.
Bye
Sven
--- os/subst.c Tue Aug 31 14:40:29 1999
+++ Src/subst.c Tue Aug 31 14:40:34 1999
@@ -1662,9 +1662,10 @@
int ops = opts[PROMPTSUBST], opb = opts[PROMPTBANG];
int opp = opts[PROMPTPERCENT], len;
- opts[PROMPTPERCENT] = 1;
- if (presc < 2)
+ if (presc < 2) {
+ opts[PROMPTPERCENT] = 1;
opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
+ }
if (isarr) {
char **ap;
diff -u od/Zsh/expn.yo Doc/Zsh/expn.yo
--- od/Zsh/expn.yo Tue Aug 31 14:41:26 1999
+++ Doc/Zsh/expn.yo Tue Aug 31 14:42:15 1999
@@ -606,8 +606,8 @@
Expand all tt(%) escapes in the resulting words in the same way as in
prompts (see noderef(Prompt Expansion)). If this flag is given twice,
full prompt expansion is done on the resulting words, depending on the
-setting of the tt(PROMPT_SUBST) and tt(PROMPT_BANG) options. The
-tt(PROMPT_PERCENT) option is temporarily turned on in any case.
+setting of the tt(PROMPT_PERCENT), tt(PROMPT_SUBST) and
+tt(PROMPT_BANG) options.
)
item(tt(X))(
With this flag parsing errors occuring with the tt(Q) flag or the
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-08-31 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-31 12:43 Sven Wischnowsky [this message]
1999-09-01 8:35 ` Peter Stephenson
-- strict thread matches above, loose matches on Subject: below --
1999-09-01 9:33 Sven Wischnowsky
1999-08-31 11:45 Sven Wischnowsky
1999-08-31 12:25 ` Zefram
1999-08-30 9:39 Sven Wischnowsky
1999-08-31 9:29 ` Zefram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199908311243.OAA29911@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).