* recexact in 3.1.6
@ 1999-09-01 0:18 Will Day
1999-09-01 9:55 ` Sven Wischnowsky
0 siblings, 1 reply; 4+ messages in thread
From: Will Day @ 1999-09-01 0:18 UTC (permalink / raw)
To: zsh workers mailing list
[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]
Option "recexact" doesn't seem to work quite right for me under 3.1.6, or
at least not as well as it did under 3.1.5:
Under 3.1.5:
% /usr/local/bin/zsh-3.1.5 -f
% setopt recexact menucomplete noautolist noautomenu
% touch note note.old
% ls
note note.old
% vi note<TAB>
-> % vi note # (where # indicates cursor position)
Under 3.1.6:
% /usr/local/bin/zsh-3.1.6 -f
% setopt recexact menucomplete noautolist noautomenu
% touch note note.old
% ls
note note.old
% vi note<TAB>
(beep)
-> % vi note#
Besides a beep when I didn't expect one, it tends to make me think that I
mis-typed something, because it's the same behavior as if I were trying to
complete a non-existant file:
% ls
% vi badfile<TAB>
(beep)
-> % vi badfile#
At least now I finally know why zsh has been beeping at me so much
recently. :) Looking over Src/Zle/zle_tricky., I can see where
do_ambiguous() handles REC_EXACT, but after substituting all the
variables, it appears to handle it only if:
isset(RECEXACT) && unset(MENUCOMPLETE)
whereas before it appeared to be if:
isset(RECEXACT) && (unset(MENUCOMPLETE) || unset(AUTOMENU))
--
Will Day <PGP mail preferred> OIT / O&E / Technical Support
willday@rom.oit.gatech.edu Georgia Tech, Atlanta 30332-0715
-> Opinions expressed are mine alone and do not reflect OIT policy <-
Those who would give up essential Liberty, to purchase a little temporary
Safety, deserve neither Liberty nor Safety.
Benjamin Franklin, Pennsylvania Assembly, Nov. 11, 1755
[-- Attachment #2: Type: application/pgp-signature, Size: 344 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: recexact in 3.1.6
@ 1999-09-01 9:55 ` Sven Wischnowsky
1999-09-01 15:54 ` Bart Schaefer
1999-09-01 18:09 ` Will Day
0 siblings, 2 replies; 4+ messages in thread
From: Sven Wischnowsky @ 1999-09-01 9:55 UTC (permalink / raw)
To: zsh-workers
Will Day wrote:
> Option "recexact" doesn't seem to work quite right for me under 3.1.6, or
> at least not as well as it did under 3.1.5:
We had some changes to the option handling some months ago but I don't
rmember everything about it.
Maybe this is just a remnant of times where we didn't have the extra
code to find out if the string on the line was inserted by the
completion code or if it was typed by the user. If it is, the patch
below is probably the right thing.
Since I don't use REC_EXACT, I have to ask for everyone's help here to
tell me if the behavior with the patch below is what you want/like/expect.
Bye
Sven
diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c Tue Aug 31 13:25:43 1999
+++ Src/Zle/zle_tricky.c Wed Sep 1 11:50:58 1999
@@ -4482,7 +4482,7 @@
hasunqu = 0;
useline = (lst != COMP_LIST_COMPLETE);
- useexact = (isset(RECEXACT) && usemenu != 1);
+ useexact = isset(RECEXACT);
uselist = (useline ?
((isset(AUTOLIST) && !isset(BASHAUTOLIST)) ?
(isset(LISTAMBIGUOUS) ? 3 : 2) : 0) : 1);
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: recexact in 3.1.6
1999-09-01 9:55 ` Sven Wischnowsky
@ 1999-09-01 15:54 ` Bart Schaefer
1999-09-01 18:09 ` Will Day
1 sibling, 0 replies; 4+ messages in thread
From: Bart Schaefer @ 1999-09-01 15:54 UTC (permalink / raw)
To: zsh workers mailing list
On Aug 31, 8:18pm, Will Day wrote:
} Subject: recexact in 3.1.6
}
} Option "recexact" doesn't seem to work quite right for me under 3.1.6, or
} at least not as well as it did under 3.1.5:
It's not supposed to work quite the same way that it did under 3.1.5; see
zsh-workers/4132 and 4148.
On Sep 1, 11:55am, Sven Wischnowsky wrote:
} Subject: Re: recexact in 3.1.6
}
} Since I don't use REC_EXACT, I have to ask for everyone's help here to
} tell me if the behavior with the patch below is what you want/like/expect.
It appears to be unchanged with respect to 4148, so I think this is fine.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: recexact in 3.1.6
1999-09-01 9:55 ` Sven Wischnowsky
1999-09-01 15:54 ` Bart Schaefer
@ 1999-09-01 18:09 ` Will Day
1 sibling, 0 replies; 4+ messages in thread
From: Will Day @ 1999-09-01 18:09 UTC (permalink / raw)
To: zsh workers mailing list
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
A short time ago, at a computer terminal far, far away, Sven Wischnowsky wrote:
>Since I don't use REC_EXACT, I have to ask for everyone's help here to
>tell me if the behavior with the patch below is what you want/like/expect.
It works great for me - Thanks.
--
Will Day <PGP mail preferred> OIT / O&E / Technical Support
willday@rom.oit.gatech.edu Georgia Tech, Atlanta 30332-0715
-> Opinions expressed are mine alone and do not reflect OIT policy <-
Those who would give up essential Liberty, to purchase a little temporary
Safety, deserve neither Liberty nor Safety.
Benjamin Franklin, Pennsylvania Assembly, Nov. 11, 1755
[-- Attachment #2: Type: application/pgp-signature, Size: 344 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~1999-09-01 18:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-09-01 0:18 recexact in 3.1.6 Will Day
1999-09-01 9:55 ` Sven Wischnowsky
1999-09-01 15:54 ` Bart Schaefer
1999-09-01 18:09 ` Will Day
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).