From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: Completion/User/_cvs again.
Date: Wed, 8 Sep 1999 10:27:16 +0200 (MET DST) [thread overview]
Message-ID: <199909080827.KAA05096@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Tanaka Akira's message of 08 Sep 1999 07:58:06 +0900
Tanaka Akira wrote:
> Also, I found that `cvs diff <TAB>' causes core dump.
>
> Z(2):akr@is27e1u11% Src/zsh -f
> is27e1u11% bindkey -e; fpath=($PWD/Completion/*(/)); autoload -U compinit; compinit -D; compdef _tst tst
> is27e1u11% compconf group_matches=yes message_format='%d' description_format='%d' describe_options=yes
> is27e1u11% cvs diff zsh: segmentation fault (core dumped) Src/zsh -f
Whoa! `bslashquote()' used a static buffer -- too short for long lists
like these (called via the `(q)' param flag).
Bart: `bslashquote()' is basically the `quotename()' from zle_tricky.c,
I think we should change it there, too.
Bye
Sven
diff -u os/utils.c Src/utils.c
--- os/utils.c Tue Sep 7 13:15:41 1999
+++ Src/utils.c Wed Sep 8 10:15:50 1999
@@ -2963,7 +2963,8 @@
bslashquote(const char *s, char **e, int instring)
{
const char *u, *tt;
- char *v, buf[PATH_MAX * 2];
+ char *v;
+ VARARR(char, buf, 2 * strlen(s) + 1);
int sf = 0;
tt = v = buf;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-09-08 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-08 8:27 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-09-08 7:08 Sven Wischnowsky
1999-09-07 11:51 Sven Wischnowsky
1999-09-07 11:22 Sven Wischnowsky
1999-09-07 7:17 Sven Wischnowsky
1999-09-07 10:47 ` Tanaka Akira
1999-09-07 22:26 ` Bart Schaefer
1999-09-07 22:58 ` Tanaka Akira
1999-09-08 0:46 ` Bart Schaefer
1999-09-06 18:10 Tanaka Akira
1999-09-07 21:06 ` Bart Schaefer
1999-09-07 23:22 ` Tanaka Akira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199909080827.KAA05096@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).