From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Re: BUG: coredump with menu-select and LIST_PACKED
Date: Wed, 27 Oct 1999 10:18:32 +0200 (MET DST) [thread overview]
Message-ID: <199910270818.KAA15257@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Tue, 26 Oct 1999 16:29:03 +0000
Bart Schaefer wrote:
> The instructions that Alexandre gave were exactly what I did to produce
> the stack trace.
I finally had the idea that `M-m' was bound to `menu-select' and after
a bit of trying, I finally could reproduce it. The problem was that
the data wasn't re-calculated when the new list of matches was
generated.
But before I found that, I found another problem with menu-select --
there still was a reference to `ZLS_SELECT'. I have no idea how this
survived.
Bye
Sven
diff -u os/Zle/complist.c Src/Zle/complist.c
--- os/Zle/complist.c Tue Oct 26 13:11:00 1999
+++ Src/Zle/complist.c Wed Oct 27 09:56:50 1999
@@ -251,6 +251,7 @@
/* Information about the list shown. */
static int noselect, mselect, inselect, mcol, mline, mcols, mlines, mmlen;
+static int selected;
static Cmatch **mtab, **mmtabp;
static Cmgroup *mgtab, *mgtabp;
static struct listcols mcolors;
@@ -567,6 +568,7 @@
inselect = 1;
if (noselect)
break;
+ selected = 1;
if (!i) {
i = mcols * mlines;
while (i--)
@@ -876,8 +878,9 @@
int d = 0;
if (!minfo.cur) {
+ selected = 0;
menucomplete(args);
- if ((minfo.cur && minfo.asked == 2) || getsparam("ZLS_SELECT"))
+ if ((minfo.cur && minfo.asked == 2) || selected)
return 0;
d = 1;
}
diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c Tue Oct 26 13:11:01 1999
+++ Src/Zle/zle_tricky.c Wed Oct 27 10:14:21 1999
@@ -5915,6 +5915,7 @@
hasperm = 1;
permmnum = mn - 1;
permgnum = gn - 1;
+ listdat.valid = 0;
return fi;
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
reply other threads:[~1999-10-27 8:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199910270818.KAA15257@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).