From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: unhappy signals
Date: Thu, 28 Oct 1999 10:59:36 +0200 (MET DST) [thread overview]
Message-ID: <199910280859.KAA19136@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Clint Adams's message of Wed, 27 Oct 1999 16:08:15 -0400
Clint Adams wrote:
> % TRAPEXIT() { print boom }
> % exit
> boom
> zsh: 8101 segmentation fault (core dumped) zsh -f
>
>
> Reversing the removehashnode hunk in 7349 fixes this,
> but of course the TRAPQUIT example now segfaults.
>
> What to do?
The problem occurred as soon as a functions was called...
The problem was that `dosavetrap()' when called from `starttrapscope()'
removed the definition for `TRAPEXIT()' but didn't reset the entry for
it in `sigtrapped[]'. In `endtrapscope()' we tested `sigtrapped[SIGEXIT]'
which was still `!= 0' even though we had removed the handler function.
Then we tried to get the function definition, got a NULL pointer and
later tried to execute that. Bang.
This patch resets the `sigtrapped[]' entry in `dosavetrap()'. I'm not
sure if this is enough, maybe we have to execute some code from
`unsettrap()' there, too. So I think the final solution has to wait
until Peter reappears.
Bye
Sven
diff -u oldsrc/signals.c Src/signals.c
--- oldsrc/signals.c Thu Oct 28 10:12:49 1999
+++ Src/signals.c Thu Oct 28 10:52:57 1999
@@ -668,6 +668,7 @@
st->list = sigfuncs[sig];
unsettrap(sig);
}
+ sigtrapped[sig] = 0;
notrapfree--;
PERMALLOC {
if (!savetraps)
@@ -829,6 +830,7 @@
if (sigtrapped[sig])
unsettrap(sig);
+ sigtrapped[sig] = st->flags;
if (st->flags) {
List list = (st->flags & ZSIG_FUNC) ?
((Shfunc) st->list)->funcdef : (List) st->list;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-10-28 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-28 8:59 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-10-27 20:08 Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199910280859.KAA19136@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).