From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: completion cleanup
Date: Wed, 3 Nov 1999 09:04:04 +0100 (MET) [thread overview]
Message-ID: <199911030804.JAA00408@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Tue, 2 Nov 1999 17:44:27 +0000
Bart Schaefer wrote:
> On Nov 1, 8:50am, Sven Wischnowsky wrote:
> } Subject: Re: PATCH: completion cleanup
> }
> } Ohhh, noooo!
> }
> } I sent the wrong uu-file. I'm so sorry. And ashamed. Ahem.
>
> The wrong diff (8475) contained a hunk to have compinit call zmodload on
> the parameter and zleparameter modules. This latest one (8478) does not
> include that hunk. Is it needed or not?
It is not needed since 8440 made them be autoloaded.
However, after adding the `funcstack' parameter, I made the parameter
module be loaded in `compinit' because I wanted to make sure that this
parameter is always correct (if the module is loaded when there are
already functions currently being executed, these functions will be
missing from `funcstack').
So, Felix Rosencrantz wrote:
> I started pulling zsh from Tanaka's CVS repository, and was seeing a few
> undefined functions due to the separation of all the completion code.
> So I started compiling without dynamic loading support, to find these
> problems at link time rather than run time.
I hope 8490 already fixed these...
> Once I got a good build, I found that the compinit function fails
> because it calls "zmodload -i parameter". Zsh reports "bad option:-i".
> In builtin.c, there is an #ifdef that controls what command line options
> are valid for zmodload depending on whether or not dynamic loading is
> enabled.
Ouch, hadn't thought of that.
> What is the proper solution to this problem?
>
> Should compinit (and any other functions) be changed to check if it
> is in a dynamic loading situation before calling zmodload? Or should
> zmodload be modified to ignore "-i" (and other flags) in non-dyanmic
> loading situations?
I think the static linked version of `zmodload' should be quiet (and
do nothing) if the module we attempt to load is linked in and should
barf otherwise.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-11-03 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-03 8:04 Sven Wischnowsky [this message]
1999-11-03 10:07 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-05-02 8:22 Sven Wischnowsky
1999-11-01 7:50 Sven Wischnowsky
1999-11-02 17:44 ` Bart Schaefer
1999-10-29 13:01 Sven Wischnowsky
1999-10-29 12:51 Sven Wischnowsky
1999-10-29 19:45 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199911030804.JAA00408@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).