From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: line count imprecision in calclist()
Date: Mon, 8 Nov 1999 09:24:14 +0100 (MET) [thread overview]
Message-ID: <199911080824.JAA13035@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Clint Adams's message of Sun, 7 Nov 1999 22:09:50 -0500
Clint Adams wrote:
> ...
>
> You should now have a situation wherein you can type
>
> ls /tmp/xxxxx/yyy/zzzzz/<TAB>
>
> and find your cursor a line too high. Behavior is normal if no scrolling
> occurs. If you rename the i+ file to something two characters shorter,
> the cursor will be two lines too high.
>
> It seems to have something to do with
> glines += 1 + ((1 + mlens[m->gnum]) / columns);
> in calclist() when mlens[m->gnum] is 79 (and therefore glines += 2).
>
>
> This seems to correct the problem..
>
> --- compresult.c 1999/11/05 09:10:44 1.1.1.3
> +++ compresult.c 1999/11/08 03:05:58
> @@ -1287,7 +1287,7 @@
> if (!(m->flags & CMF_DISPLINE))
> glines += 1 + (mlens[m->gnum] / columns);
> } else if (!(m->flags & CMF_NOLIST))
> - glines += 1 + ((1 + mlens[m->gnum]) / columns);
> + glines += 1 + ((mlens[m->gnum]) / columns);
> }
> }
> }
>
> However, it makes me uneasy that something will break elsewhere.
No, I think that's ok (apart from: I couldn't apply the patch, due to
some whitespace difference I guess, and apart from: the patch should
have been relative to the toplevel directory -- always having to cd or
to type paths when patch asks which file to patch is a bit annoying).
Due to the way such matches are (or should be) printed, the `1 +' was
indeed wrong, just the same as the line two lines above the one you
changed.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-11-08 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-08 8:24 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-11-08 3:09 Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199911080824.JAA13035@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).