From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: BUG: 3.1.6-pws-9: problems with fignore
Date: Mon, 22 Nov 1999 10:49:15 +0100 (MET) [thread overview]
Message-ID: <199911220949.KAA05105@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: mason@primenet.com.au's message of 22 Nov 1999 02:48:53 GMT
Geoff Wing wrote:
> Heyla,
> "fignore <S> <Z> (FIGNORE <S>)
> An array (colon separated list) containing the suf-
> fixes of files to be ignored during filename com-
> pletion. However, if the completion generates only
> files which would match if this variable would be
> ignored, than these files are completed anyway."
>
> 1) fignore is for file completion, not directory completion.
Err. I always thought directories were files. And if I have a
directory named `foo~' I don't think I'd want to see it.
How about turning fignore into a style? Oops... sounds like a good
idea, doesn't it?
> 2) No completions with fignore used, but completions without it therefore
> complete without it.
>
> % mkdir /tmp/foo
> % cd /tmp/foo
> % touch BLAH.org
> % ls BLA<TAB>
Yep, thinko in addmatches(): fignore should only be used when really
adding matches otherwise the possible matches get sorted out before we
know that there are no matches when fignore is used.
Bye
Sven
diff -u oldsrc/Zle/compcore.c Src/Zle/compcore.c
--- oldsrc/Zle/compcore.c Tue Nov 16 10:07:51 1999
+++ Src/Zle/compcore.c Mon Nov 22 10:46:57 1999
@@ -1735,7 +1735,7 @@
}
sl = strlen(s);
isalt = oisalt;
- if ((!dat->psuf || !*(dat->psuf)) && aign) {
+ if (doadd && (!dat->psuf || !*(dat->psuf)) && aign) {
/* Do the suffix-test. If the match has one of the
* suffixes from ign, we put it in the alternate set. */
char **pt = aign;
@@ -1745,12 +1745,6 @@
if ((filell = strlen(*pt)) < sl
&& !strcmp(*pt, s + sl - filell))
isalt = 1;
-
- if (isalt && !doadd) {
- if (dparr && !*++dparr)
- dparr = NULL;
- continue;
- }
}
if (!(dat->aflags & CAF_MATCH)) {
if (dat->aflags & CAF_QUOTE)
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-11-22 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-22 9:49 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-11-22 2:48 Geoff Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199911220949.KAA05105@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).