From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: zftp without inet_aton()
Date: Wed, 1 Dec 1999 10:09:24 +0100 (MET) [thread overview]
Message-ID: <199912010909.KAA14478@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: zefram@fysh.org's message of Tue, 30 Nov 1999 18:15:27 +0000
Zefram wrote:
> This should fix zftp for systems that lack inet_aton(). I haven't tested
> it on such a system, however.
It doesn't. For me at least:
gcc -c -I. -DHAVE_CONFIG_H -DMODULE -Wall -Wno-implicit -Wmissing-prototypes -ggdb
-fpic -o zftp..o zftp.c
In file included from zftp.c:53:
zftp.pro:35: warning: `struct in_addr' declared inside parameter list
zftp.pro:35: warning: its scope is only this definition or declaration,
zftp.pro:35: warning: which is probably not what you want.
In file included from zftp.c:60:
/usr/include/arpa/inet.h:72: conflicting types for `inet_aton'
zftp.pro:35: previous declaration of `inet_aton'
make[2]: *** [zftp..o] Error 1
Quick fix below (can't move the includes below the arpa thingies
because at least my arpa/telnet.h #defines DO, which would then cause
mishap in zsh.h:212).
Bye
Sven
--- Src/Modules/zftp.c.old Wed Dec 1 10:04:32 1999
+++ Src/Modules/zftp.c Wed Dec 1 10:05:58 1999
@@ -49,14 +49,15 @@
struct zftp_session;
typedef struct zftp_session *Zftp_session;
-#include "zftp.mdh"
-#include "zftp.pro"
-
#include <sys/socket.h>
#include <netdb.h>
#include <netinet/in_systm.h>
#include <netinet/in.h>
#include <netinet/ip.h>
+
+#include "zftp.mdh"
+#include "zftp.pro"
+
#include <arpa/inet.h>
/* it's a TELNET based protocol, but don't think I like doing this */
#include <arpa/telnet.h>
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-12-01 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-01 9:09 Sven Wischnowsky [this message]
1999-12-01 9:30 ` Zefram
-- strict thread matches above, loose matches on Subject: below --
1999-11-30 18:15 zefram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199912010909.KAA14478@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).