zsh-workers
 help / color / mirror / code / Atom feed
* PATCH: a couple of Makefile fixes
@ 1999-12-08 14:40 zefram
  1999-12-08 17:02 ` Bart Schaefer
  0 siblings, 1 reply; 2+ messages in thread
From: zefram @ 1999-12-08 14:40 UTC (permalink / raw)
  To: zsh-workers

"make distclean" reveals two small bugs:

1. The Test subdirectory needs to be entered for cleaning.

2. There is a very long-standing bug that causes stamp-h.in to be created
   in the wrong directory if it doesn't already exist.  I remember fixing
   this several years ago, but the change evidently disappeared sometime
   since.

-zefram

*** ../zsh-cvs-snapshot-08.12.1999.04.04.02/Makefile.in	Mon Dec  6 04:33:02 1999
--- Makefile.in	Wed Dec  8 14:10:52 1999
***************
*** 98,103 ****
--- 98,104 ----
  distclean-here:
  	@cd Completion && $(MAKE) $(MAKEDEFS) $@
  	@cd Functions && $(MAKE) $(MAKEDEFS) $@
+ 	@cd Test && $(MAKE) $(MAKEDEFS) $@
  	rm -f Makefile config.h config.status config.log config.cache stamp-h Config/defs.mk
  
  realclean-here:
***************
*** 123,129 ****
  config.h.in: stamp-h.in
  stamp-h.in: configure.in acconfig.h aclocal.m4 aczsh.m4
  	cd $(sdir) && autoheader
! 	echo > $@
  
  # ========== DEPENDENCIES FOR DISTRIBUTION ==========
  
--- 124,130 ----
  config.h.in: stamp-h.in
  stamp-h.in: configure.in acconfig.h aclocal.m4 aczsh.m4
  	cd $(sdir) && autoheader
! 	echo > $(sdir)/stamp-h.in
  
  # ========== DEPENDENCIES FOR DISTRIBUTION ==========
  
END


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: a couple of Makefile fixes
  1999-12-08 14:40 PATCH: a couple of Makefile fixes zefram
@ 1999-12-08 17:02 ` Bart Schaefer
  0 siblings, 0 replies; 2+ messages in thread
From: Bart Schaefer @ 1999-12-08 17:02 UTC (permalink / raw)
  To: zefram, zsh-workers

On Dec 8,  2:40pm, zefram@fysh.org wrote:
} Subject: PATCH: a couple of Makefile fixes
}
} --- 124,130 ----
}   config.h.in: stamp-h.in
}   stamp-h.in: configure.in acconfig.h aclocal.m4 aczsh.m4
}   	cd $(sdir) && autoheader
} ! 	echo > $(sdir)/stamp-h.in
}   
}   # ========== DEPENDENCIES FOR DISTRIBUTION ==========
}   

I've been wondering about stuff like this.  Note that this now does not
actually create the file that's the target.  Shouldn't it read:

config.h.in: $(sdir)/stamp-h.in
$(sdir)/stamp-h.in: configure.in acconfig.h aclocal.m4 aczsh.m4

??
Maybe it even needs to be

$(sdir)/config.h.in: $(sdir)/stamp-h.in

??

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1999-12-08 17:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-12-08 14:40 PATCH: a couple of Makefile fixes zefram
1999-12-08 17:02 ` Bart Schaefer

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).