From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: 3.1.6-pws-11: Completion suggestions + fixes + sorting tags
Date: Thu, 16 Dec 1999 09:34:56 +0100 (MET) [thread overview]
Message-ID: <199912160834.JAA11625@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Wed, 15 Dec 1999 20:31:27 +0000
Peter Stephenson wrote:
> Sven Wischnowsky wrote:
> > > 2. I don't really like the way ZLS_COLORS is sidelined. There doesn't seem
> > > to be any point in it if you're using new completion. Perhaps if it's
> > > set when completion is initialised it could be set to the default for
> > > the list-colors style.
> >
> > Hm, my bad English shows... There doesn't seem to be a point in what?
>
> Currently (well... a week ago, and a week is a long time in completion), if
> you set ZLS_COLORS and use completion, ZLS_COLORS gets stomped on. I was
> suggesting that compinit might instead save it as the list-colors default,
> if that's not already set; this can of course be overridden. (It's nice
> that styles don't care whether or not the module they refer to has been
> initialised, unlike assoc arrays.)
Ah yes. I had thought about that, too. Then I thought that this
wouldn't work if ZLS_COLO(|U)RS get set up after compinit is loaded
and wanted to think some more about this. This then I forgot to do.
Why not...
Bye
Sven
diff -ru ../z.old/Completion/Core/compinit Completion/Core/compinit
--- ../z.old/Completion/Core/compinit Thu Dec 16 09:24:05 1999
+++ Completion/Core/compinit Thu Dec 16 09:32:17 1999
@@ -478,7 +478,7 @@
zstyle ':completion:correct' max-errors '2' numeric
zstyle ':completion:correct' prompt 'correct to:'
zstyle ':completion:*' completer '_complete'
-zstyle ':completion*:default' list-colors no=0 fi=0 di=0 ln=0 pi=0 so=0 bd=0 cd=0 ex=0
+zstyle ':completion*:default' list-colors "${(s.:.)ZLS_COLORS:-${ZLS_COLOURS:-no=0:fi=0:di=0:ln=0:pi=0:so=0:bd=0:cd=0:ex=0}}"
zstyle ':completion:*' tag-order 'arguments values' options \
globbed-files directories all-files
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-12-16 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-16 8:34 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-12-16 8:28 Sven Wischnowsky
1999-12-15 9:09 Sven Wischnowsky
1999-12-15 18:35 ` Bart Schaefer
1999-12-15 20:31 ` Peter Stephenson
1999-12-14 21:56 Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199912160834.JAA11625@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).