From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7512 invoked by alias); 3 Feb 2016 15:17:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 37874 Received: (qmail 8587 invoked from network); 3 Feb 2016 15:17:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Another unused function argument in sched.c From: "Jun T." In-Reply-To: <42271C6F-3808-421A-B9DB-A66AE7CFFBA9@kba.biglobe.ne.jp> Date: Thu, 4 Feb 2016 00:17:02 +0900 Content-Transfer-Encoding: quoted-printable Message-Id: <19E6ACAC-35B3-4972-824C-A486AEA7A0CC@kba.biglobe.ne.jp> References: <42271C6F-3808-421A-B9DB-A66AE7CFFBA9@kba.biglobe.ne.jp> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1878.6) X-Biglobe-Spnum: 63901 2016/01/30 00:06, I wrote: > In function schedaddtimed(time_t t) (Src/Builtins/sched.c, line 61) > the argument 't' is not used. Is this OK? (i.e., remove the argument 't') diff --git a/Src/Builtins/sched.c b/Src/Builtins/sched.c index 1b9c68f..70625ed 100644 --- a/Src/Builtins/sched.c +++ b/Src/Builtins/sched.c @@ -58,7 +58,7 @@ static int schedcmdtimed; =20 /**/ static void -schedaddtimed(time_t t) +schedaddtimed(void) { /* * The following code shouldn't be necessary and indicates @@ -140,7 +140,7 @@ checksched(void) */ DPUTS(timedfns && firstnode(timedfns), "BUG: already timed fn (1)"); - schedaddtimed(schedcmds->time); + schedaddtimed(); } } } @@ -180,7 +180,7 @@ bin_sched(char *nam, char **argv, UNUSED(Options = ops), UNUSED(int func)) schedcmds =3D sch->next; if (schedcmds) { DPUTS(timedfns && firstnode(timedfns), "BUG: already = timed fn (2)"); - schedaddtimed(schedcmds->time); + schedaddtimed(); } } zsfree(sch->cmd); @@ -317,7 +317,7 @@ bin_sched(char *nam, char **argv, UNUSED(Options = ops), UNUSED(int func)) sch->next =3D schedcmds; schedcmds =3D sch; DPUTS(timedfns && firstnode(timedfns), "BUG: already timed = fn (3)"); - schedaddtimed(t); + schedaddtimed(); } else { for (sch2 =3D schedcmds; sch2->next && sch2->next->time < sch->time; @@ -330,7 +330,7 @@ bin_sched(char *nam, char **argv, UNUSED(Options = ops), UNUSED(int func)) sch->next =3D NULL; schedcmds =3D sch; DPUTS(timedfns && firstnode(timedfns), "BUG: already timed fn = (4)"); - schedaddtimed(t); + schedaddtimed(); } return 0; }