From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Tim Lee" <progscriptclone@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Improve vcs_info example for ahead/behind git commits
Date: Mon, 29 Mar 2021 11:50:17 +0000 [thread overview]
Message-ID: <1b0343d9-87c2-4a0d-860f-30a390d7034d@www.fastmail.com> (raw)
In-Reply-To: <20210329103927.qzky3fyevptfflvj@home-guest>
Tim Lee wrote on Mon, 29 Mar 2021 10:39 +00:00:
> > > > > diff --git a/Misc/vcs_info-examples b/Misc/vcs_info-examples
> > > > > index 94b8a7b5e..36d4d3bf8 100644
> > > > > --- a/Misc/vcs_info-examples
> > > > > +++ b/Misc/vcs_info-examples
> > > > > @@ -179,14 +179,18 @@ function +vi-git-st() {
> > > > > local ahead behind
> > > > > local -a gitstatus
> > > > >
> > > > > - # for git prior to 1.7
> > > > > + # for git prior to 1.7.0
> > > > > # ahead=$(git rev-list origin/${hook_com[branch]}..HEAD | wc -l)
> > > > > - ahead=$(git rev-list ${hook_com[branch]}@{upstream}..HEAD 2>/dev/null | wc -l)
> > > > > + # for git 1.7.0 and 1.7.1
> > > > > + # ahead=$(git rev-list @{upstream}..HEAD 2>/dev/null | wc -l)
> > > > > + ahead=$(git rev-list --count @{upstream}..HEAD 2>/dev/null)
> > > > > (( $ahead )) && gitstatus+=( "+${ahead}" )
> > > >
> > > > The version of this function in my zshrc starts like this:
> > > > .
> > > > git rev-parse @{upstream} >/dev/null 2>&1 || return 0
> > > > local -a x=( $(git rev-list --left-right --count HEAD...@{upstream} ) )
> > >
> > > The snippet below displays N/M. How would you make it display +N/-M
> > > instead?
> >
> > Change the last line to hook_com[misc]="+${x[1]} -${x[2]}".
>
> But hook_com[misc]="+${x[1]} -${x[2]}" would display a '+0' and/or '-0'
> when the local git branch is not ahead-of or behind the remote branch.
>
> The existing example does not display '+0' or '-0'.
You didn't specify this when you asked. Anyway, if you want not to show
+0 or -0, then add the appropriate logic — e.g., «if (( x[2] )); then».
We're on -workers@ so I thought that'd go without saying.
A bit further out along the "readable"–"line noise" spectrum there is
this alternative:
hook_com[misc]="+$x[1]/-$x[2]"
hook_com[misc]=${${hook_com[misc]#'+0/'}%'/-0'}
Cheers,
Daniel
next prev parent reply other threads:[~2021-03-29 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 21:36 Tim Lee
2021-03-29 7:06 ` Daniel Shahaf
2021-03-29 9:30 ` Tim Lee
2021-03-29 9:52 ` Daniel Shahaf
2021-03-29 10:39 ` Tim Lee
2021-03-29 11:50 ` Daniel Shahaf [this message]
2021-04-10 20:51 ` Lawrence Velázquez
2021-04-13 11:34 ` Daniel Shahaf
2021-04-13 11:58 ` Tim Lee
2021-04-13 14:01 ` Daniel Shahaf
2021-04-13 15:01 ` Tim Lee
2021-03-29 15:20 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b0343d9-87c2-4a0d-860f-30a390d7034d@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=progscriptclone@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).