From: jarausch@igpm.rwth-aachen.de
To: schizo@debian.org
Cc: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: struct heap 64-bit
Date: Tue, 04 Jan 2000 17:06:50 +0100 [thread overview]
Message-ID: <200001041606.RAA72897@numa1.igpm.rwth-aachen.de> (raw)
In-Reply-To: <20000104105536.A8967@dman.com>
On 4 Jan, Clint Adams wrote:
>> What's the intent?
>
> Helmut fixed this in 9186 but the patch was reversed.
>
> This just gets rid of the overcompensation altogether.
> Incidentally, this solves the bus error problem I was
> experiencing on 64-bit SPARC Linux.
>
> Index: Src/zsh.h
> ===================================================================
> RCS file: /cvs/zsh/zsh/Src/zsh.h,v
> retrieving revision 1.1.1.39
> diff -u -r1.1.1.39 zsh.h
> --- Src/zsh.h 1999/12/17 12:18:28 1.1.1.39
> +++ Src/zsh.h 2000/01/04 15:51:39
> @@ -1559,9 +1559,6 @@
> size_t size; /* size of heap */
> size_t used; /* bytes used from the heap */
> struct heapstack *sp; /* used by pushheap() to save the value used */
> -#ifdef PAD_64_BIT
> - size_t dummy; /* Make sure sizeof(heap) is a multiple of 8 */
> -#endif
> #define arena(X) ((char *) (X) + sizeof(struct heap))
> };
>
I don't think this is a good solution.
My patch added a comment and left the code commented.
When somebody adds a new member to struct heap next time, he/she will
then be reminded to reenable that code to pad the struct to a multiple
of 64 bits.
Helmut.
--
Helmut Jarausch
Lehrstuhl fuer Numerische Mathematik
Institute of Technology, RWTH Aachen
D 52056 Aachen, Germany
next prev parent reply other threads:[~2000-01-04 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-30 7:51 Glob problem with memory Felix Rosencrantz
2000-01-01 16:55 ` Peter Stephenson
2000-01-03 10:11 ` jarausch
2000-01-03 11:54 ` jarausch
2000-01-03 12:01 ` 64_bit logical is broken (was Re: Glob problem with memory) jarausch
2000-01-04 15:55 ` PATCH: struct heap 64-bit Clint Adams
2000-01-04 16:06 ` jarausch [this message]
2000-01-04 16:41 ` Tanaka Akira
2000-01-04 17:25 ` Clint Adams
2000-01-04 17:30 ` Tanaka Akira
2000-01-01 17:16 ` Glob problem with memory Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200001041606.RAA72897@numa1.igpm.rwth-aachen.de \
--to=jarausch@igpm.rwth-aachen.de \
--cc=schizo@debian.org \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).