RE: dev-15: accept-and-menu-complete and suffix in braces

RE: dev-15: accept-and-menu-complete and suffix in braces

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> > Yes, we had. And I don't get the behaviour you describe (neither for
> > in-brace-completion nor anywhere else)... any funny option/style settings?
> >
> 
> itsrm2% compstyle '*:paths' cursor 'yes'

When inside a word it can't auto-remove the suffix and with
compstate[to_end]='' it didn't check if it was at the end...

Bye
 Sven

diff -ru ../z.old/Src/Zle/compresult.c Src/Zle/compresult.c
--- ../z.old/Src/Zle/compresult.c	Thu Jan 27 17:06:56 2000
+++ Src/Zle/compresult.c	Thu Jan 27 17:14:59 2000
@@ -719,7 +719,8 @@
 	/* We are currently not in a menu-completion, *
 	 * so set the position variables.             */
 	minfo.pos = wb;
-	minfo.we = (movetoend >= 2 || (movetoend == 1 && !menucmp));
+	minfo.we = (movetoend >= 2 || (movetoend == 1 && !menucmp) ||
+		    (!movetoend && cs == we));
 	minfo.end = we;
     }
     /* If we are already in a menu-completion or if we have done a *

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

RE: dev-15: accept-and-menu-complete and suffix in braces

[Andrej Borsenkow]

>
> Yes, we had. And I don't get the behaviour you describe (neither for
> in-brace-completion nor anywhere else)... any funny option/style settings?
>

itsrm2% compstyle '*:paths' cursor 'yes'

/andrej

Re: dev-15: accept-and-menu-complete and suffix in braces

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> I noted, that suffix is not removed when next match is inserted with a-a-m-c
> in selection. Here an example:
> 
> bor@itsrm2% sudo rm
> /tools/lib/zsh/{3.1.6/,3.1.6-bart-7/,3.1.6-bart-8/,3.1.6-dev
> -14/,3.1.6-pws-1/
> 3.1.6/         3.1.6-dev-14/  3.1.6-pws-10/  3.1.6-pws-2/
> 3.1.6-bart-7/  3.1.6-dev-15/  3.1.6-pws-11/  3.1.6-pws-3/
> 3.1.6-bart-8/  3.1.6-pws-1/   3.1.6-pws-12/  3.1.6-pws-6/
> 
> Note, that slash is retained. It may not matter in this particular case, but
> in general it may be problem.
> 
> Hmm ... did not we have this already?

Yes, we had. And I don't get the behaviour you describe (neither for
in-brace-completion nor anywhere else)... any funny option/style settings?

> This is with dev-15; had no time to try dev-16 yet.

Unless I'm missing something obvious again, this shouldn't have
changed (I tried it with the CVS-version).

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

RE: dev-15: accept-and-menu-complete and suffix in braces

[Andrej Borsenkow]

Actually, it applies to every use of a-a-m-c, not only inside of braces. At
least with directories.

> I noted, that suffix is not removed when next match is inserted
> with a-a-m-c
> in selection. Here an example:
>

dev-15: accept-and-menu-complete and suffix in braces

[Andrej Borsenkow]

I noted, that suffix is not removed when next match is inserted with a-a-m-c
in selection. Here an example:

bor@itsrm2% sudo rm
/tools/lib/zsh/{3.1.6/,3.1.6-bart-7/,3.1.6-bart-8/,3.1.6-dev
-14/,3.1.6-pws-1/
3.1.6/         3.1.6-dev-14/  3.1.6-pws-10/  3.1.6-pws-2/
3.1.6-bart-7/  3.1.6-dev-15/  3.1.6-pws-11/  3.1.6-pws-3/
3.1.6-bart-8/  3.1.6-pws-1/   3.1.6-pws-12/  3.1.6-pws-6/

Note, that slash is retained. It may not matter in this particular case, but
in general it may be problem.

Hmm ... did not we have this already?

/andrej

This is with dev-15; had no time to try dev-16 yet.