From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: _diff (new), _prcs (upgrade)
Date: Fri, 28 Jan 2000 09:26:42 +0100 (MET) [thread overview]
Message-ID: <200001280826.JAA20090@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Alexandre Duret-Lutz's message of 27 Jan 2000 18:21:12 +0100
Alexandre Duret-Lutz wrote:
> >>> "Sven" == Sven Wischnowsky <wischnow@informatik.hu-berlin.de> writes:
>
> [...]
>
> Sven> The rest of the patch just makes some of the descriptions more
> Sven> verbose. I hope this is ok for Alexandre (?).
>
> I don't see why it shouldn't be ok.
>
> Sven> Oh, and it makes _diff_options use `$(command diff ...)' -- I at least
> Sven> have a small wrapper function for it which makes it fail otherwise.
>
> I first wrote this, and then removed 'command' when I thought that on a
> system without GNU diff a user may have installed GNU diff and made diff be
> an alias to GNU diff. But maybe it's quite uncommon especially with diff
> (which is used by several commands and is thus better put in the PATH).
>
> Also, I should say: I understand why _pids is running $(command ps ...)
> but the difference in _diff_options is that we should be testing the
> command that the user is actually running.
Actually, I wasn't too sure about _pids either... the problem is that
some users may have functions for ps, diff, and so on that may give
completely different results when invoked in the way we invoke them.
Hm. maybe we should try to solve this in a generic manner by writing a
function that is called in such cases, like:
_call <name> [ <how> ]
(i.e. we use `$(_diff ps)', `$(_call ps list)' and so on).
_call would then first see if there is a style `command-line' for the
tag `<name>' or, if <how> is given, <name>-<how>. If there is such a
style it is used as an array containing the whole command line to use
(the styles for ps we have now would be removed). If there is no such
style, and $+functions[<name>] is 1, we use `command <name>',
otherwise we use just `<name>'.
Does this sound reasonable?
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-01-28 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-01-28 8:26 Sven Wischnowsky [this message]
2000-01-28 9:49 ` Alexandre Duret-Lutz
-- strict thread matches above, loose matches on Subject: below --
2000-01-31 9:09 Sven Wischnowsky
2000-01-28 15:11 Sven Wischnowsky
2000-01-28 16:24 ` Alexandre Duret-Lutz
2000-01-28 10:25 Sven Wischnowsky
2000-01-28 15:04 ` Alexandre Duret-Lutz
2000-01-27 16:08 Sven Wischnowsky
2000-01-27 17:21 ` Alexandre Duret-Lutz
2000-01-29 8:49 ` Alexandre Duret-Lutz
2000-01-27 14:52 Alexandre Duret-Lutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200001280826.JAA20090@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).