From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: job-control
Date: Tue, 1 Feb 2000 11:58:27 +0100 (MET) [thread overview]
Message-ID: <200002011058.LAA07413@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Sven Wischnowsky's message of Mon, 31 Jan 2000 13:53:36 +0100 (MET)
I wrote:
> But removing those two child_* and
> adding:
>
> if (list_pipe_job && jobtab[list_pipe_job].procs &&
> !(jobtab[list_pipe_job].stat & STAT_STOPPED))
> child_suspend(0);
>
> before the if (!list_pipe_child && ...) fixes the problem, too and is
> almost certainly better. Can anyone see a problem with this?
No, we would also need a child_block, then, so we can use
child_unblock()/child_block() after this test.
I haven't found an example where this fails...
Bye
Sven
diff -ru ../z.old/Src/exec.c Src/exec.c
--- ../z.old/Src/exec.c Tue Feb 1 11:33:24 2000
+++ Src/exec.c Tue Feb 1 11:34:43 2000
@@ -980,9 +980,12 @@
jn->stat |= STAT_NOPRINT;
makerunning(jn);
}
- if (!(jn->stat & STAT_LOCKED)) {
- child_unblock();
+ if (!(jn->stat & STAT_LOCKED))
waitjobs();
+
+ if (list_pipe_job && jobtab[list_pipe_job].procs &&
+ !(jobtab[list_pipe_job].stat & STAT_STOPPED)) {
+ child_unblock();
child_block();
}
if (list_pipe_child &&
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-02-01 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-02-01 10:58 Sven Wischnowsky [this message]
2000-02-01 16:35 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-02-02 8:25 Sven Wischnowsky
2000-01-31 12:53 Sven Wischnowsky
2000-01-31 10:00 Sven Wischnowsky
2000-01-31 10:47 ` Bart Schaefer
2000-01-31 11:52 ` Bart Schaefer
2000-01-18 11:36 Sven Wischnowsky
2000-01-29 18:13 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200002011058.LAA07413@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).