Re: PATCH: prompt escape tests

Re: PATCH: prompt escape tests

[Sven Wischnowsky]

Peter Stephenson wrote:

> If I remember, there was a failed test reported by Sven to do with
> different system behaviour which hasn't been fixed up yet.

I wanted to mention that again anyway... A collegue noticed this for
some newer Solaris version, too: nowadays some systems don't update
the atime inode field anymore when a file is read, which makes the -N
condition test fail.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: PATCH: prompt escape tests

[Tanaka Akira]

In article <200002020834.JAA09905@beta.informatik.hu-berlin.de>,
  Sven Wischnowsky <wischnow@informatik.hu-berlin.de> writes:

> I wanted to mention that again anyway... A collegue noticed this for
> some newer Solaris version, too: nowadays some systems don't update
> the atime inode field anymore when a file is read, which makes the -N
> condition test fail.

Z:akr@thorax% uname
Linux
Z:akr@thorax% df .
Filesystem           1k-blocks      Used Available Use% Mounted on
crane:/ldl3            3939604   1660770   2274895  42% /amd/crane/root/ldl3
Z:akr@thorax% make check
...
Test ./07cond.ztst failed: bad status 1, expected 0 from:
  cat unmodified
  touch newnewnew
  [[ -N newnewnew && ! -N unmodified ]]
Was testing: -N cond
./07cond.ztst: test failed.
...

This problem is not Solaris specific and can be reproduced on Linux.
I think it is caused by NFS.
-- 
Tanaka Akira

Re: PATCH: prompt escape tests

[Dan Nelson]

In the last episode (Feb 03), Tanaka Akira said:
> In article <200002020834.JAA09905@beta.informatik.hu-berlin.de>,
>   Sven Wischnowsky <wischnow@informatik.hu-berlin.de> writes:
> 
> > I wanted to mention that again anyway... A collegue noticed this
> > for some newer Solaris version, too: nowadays some systems don't
> > update the atime inode field anymore when a file is read, which
> > makes the -N condition test fail.
>
> This problem is not Solaris specific and can be reproduced on Linux.
> I think it is caused by NFS.

I think it's a POSIX requirement that atime must be updated.
 
Lots of unixes do let let you disable atime updates though (usually by
mount -o noatime).  It's useful for news servers or FTP archives that
do a lot of reading and don't really care about the atime field.  I
looked on my Solaris 2.6 box and there doesn't seem to be a way to
disable atime updates.  7 or 8 might very well be able to, though.

-- 
	Dan Nelson
	dnelson@emsphone.com

atime (Re: PATCH: prompt escape tests)

[Tanaka Akira]

In article <20000202105104.D31919@dan.emsphone.com>,
  Dan Nelson <dnelson@emsphone.com> writes:

> I think it's a POSIX requirement that atime must be updated.

Hm.

> Lots of unixes do let let you disable atime updates though (usually by
> mount -o noatime).  It's useful for news servers or FTP archives that
> do a lot of reading and don't really care about the atime field.  I
> looked on my Solaris 2.6 box and there doesn't seem to be a way to
> disable atime updates.  7 or 8 might very well be able to, though.

It's server side config and not related to this problem.

Linux produces NFS requests by `touch t':

02:26:54.406581 thorax.jaist.ac.jp.1258203975 > crane.nfs: 112 lookup fh 32,10/568960 "t" (ttl 62, id 8982)
02:26:54.408238 thorax.jaist.ac.jp.1258203976 > crane.nfs: 144 create fh 32,10/568960 "t" (ttl 62, id 8983)
02:26:54.437421 thorax.jaist.ac.jp.1258203977 > crane.nfs: 136 setattr fh 32,10/569010 (ttl 62, id 8986)

and by `cat t':

02:27:08.065326 thorax.jaist.ac.jp.1258203978 > crane.nfs: 112 lookup fh 32,10/568960 "t" (ttl 62, id 9002)
02:27:08.067635 thorax.jaist.ac.jp.1258203979 > crane.nfs: 104 getattr fh 32,10/569010 (ttl 62, id 9003)

Some requests (especialy requests by `cat t') are omitted by cache.
Anyway, the server cannot updates atime since the client doesn't send
read requests.
-- 
Tanaka Akira

PATCH: prompt escape tests

[Peter Stephenson]

I've been slow producing more tests.  This is for prompt escapes; there's a
bit in the .distfiles hunk to add Bart's funcdef test to the distribution.

As always, this is not supposed to be exhaustive:  if a particular problem
turns up, it's likely to be in something more complicated than what's been
tested, and will have to be added by hand.

If I remember, there was a failed test reported by Sven to do with
different system behaviour which hasn't been fixed up yet.

One thing that turned up here is that `prompt -P %~' doesn't work in
non-interactive shells, i.e. doesn't do the directory table lookup (or
doesn't even put it into a directory table, I haven't checked).
Whether this is intentional or not, it's not mentioned in the manual.  I
can't see any good reason for it.

Index: Test/.distfiles
===================================================================
RCS file: /home/pws/CVSROOT/projects/zsh/Test/.distfiles,v
retrieving revision 1.4
diff -u -r1.4 .distfiles
--- Test/.distfiles	2000/01/14 12:33:36	1.4
+++ Test/.distfiles	2000/02/01 20:43:58
@@ -2,5 +2,6 @@
     .cvsignore .distfiles Makefile.in
     ztst.zsh
     01grammar.ztst 02alias.ztst 03quoting.ztst 04redirect.ztst
-    05command.ztst 06arith.ztst 07cond.ztst 08traps.ztst 50cd.ztst
+    05command.ztst 06arith.ztst 07cond.ztst 08traps.ztst 09funcdef.ztst
+    10prompt.ztst 50cd.ztst
 '
Index: Test/10prompt.ztst
===================================================================
RCS file: 10prompt.ztst
diff -N 10prompt.ztst
--- /dev/null	Tue May  5 21:32:27 1998
+++ 10prompt.ztst	Tue Feb  1 20:43:33 2000
@@ -0,0 +1,106 @@
+%prep
+
+  mydir=$PWD
+  SHLVL=2
+  setopt extendedglob
+
+%test
+
+# 'mydir=$PWD; hash -d mydir; print -P %~' doesn't seem to abbreviate
+# to ~mydir in a non-interactive shell.  Is this correct?
+
+  print -P '  %%%):  %)
+  %%d:  %d
+  %%1/: %1/
+  %%h:  %h
+  %%L:  %L
+  %%M:  %M
+  %%m:  %m
+  %%n:  %n
+  %%N:  %N
+  %%i:  %i
+  a%%{...%%}b:  a%{%}b
+  '
+0q:Basic prompt escapes as shown.
+>  %):  )
+>  %d:  $mydir
+>  %1/: ${mydir:t}
+>  %h:  0
+>  %L:  2
+>  %M:  $HOST
+>  %m:  ${HOST%%.*}
+>  %n:  $USERNAME
+>  %N:  ZTST_execchunk
+>  %i:  2
+>  a%{...%}b:  ab
+>  
+
+  true
+  print -P '%?'
+  false
+  print -P '%?'
+0:`%?' prompt escape
+>0
+>1
+
+  PS4="%_> "
+  setopt xtrace
+  if true; then true; else false; fi
+  unsetopt xtrace
+0:`%_' prompt escape
+?if> true
+?then> true
+?> unsetopt xtrace
+
+  diff =(print -P '%#') =(print -P '%(!.#.%%)')
+0:`%#' prompt escape and its equivalent
+
+  psvar=(caesar adsum jam forte)
+  print -P '%v' '%4v'
+0:`%v' prompt escape
+>caesar forte
+
+  true
+  print -P '%(?.true.false)'
+  false
+  print -P '%(?.true.false)'
+0:ternary prompt escapes
+>true
+>false
+
+  print -P '%10<...<truncated at 10%<< Not truncated'
+  print -P '%10>...>truncated at 10%>> Not truncated'
+0:prompt truncation
+>...d at 10 Not truncated
+>truncat... Not truncated
+
+# It's hard to check the time and date as they are moving targets.
+# We therefore just check that various forms of the date are consistent.
+# In fact, if you perform this at midnight it can still fail.
+# We could test for that, but we can't be bothered.
+# I hope LC_ALL is enough to make the format what's expected.
+
+  LC_ALL=C
+  date1=$(print -P %w)
+  date2=$(print -P %W)
+  date3=$(print -P %D)
+  if [[ $date1 != [A-Z][a-z][a-z][[:blank:]]##[0-9]## ]]; then
+    print "Date \`$date1' is not in the form \`Day DD' (e.g. \`Mon 1'"
+  fi
+  if [[ $date2 != [0-9][0-9]/[0-9][0-9]/[0-9][0-9] ]]; then
+    print "Date \`$date2' is not in the form \`DD/MM/YYYY'"
+  fi
+  if [[ $date3 != [0-9][0-9]-[0-9][0-9]-[0-9][0-9] ]]; then
+    print "Date \`$date3' is not in the form \`YY-MM-DD'"
+  fi
+  if (( $date1[5,-1] != $date2[4,5] )) || (( $date2[4,5] != $date3[8,9] ))
+  then
+    print "Days of month do not agree in $date1, $date2, $date3"
+  fi
+  if (( $date2[1,2] != $date3[4,5] )); then
+    print "Months do not agree in $date2, $date3"
+  fi
+  if (( $date2[7,8] != $date3[1,2] )); then
+    print "Years do not agree in $date2, $date3"
+  fi
+0:Dates produced by prompt escapes

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>