From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Funny bug when autoloading with syntax error
Date: Fri, 4 Feb 2000 10:34:26 +0100 (MET) [thread overview]
Message-ID: <200002040934.KAA22630@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Thu, 03 Feb 2000 18:30:20 +0000
Peter Stephenson wrote:
> Autoload the following function:
>
> if (( 1 )): then # note colon instead of semicolon
> true
> fi
>
> This loads silently, unlike trying it at the command line which gives a
> parse error near `fi', which is not unexpected. `which fn' gives
>
> fn () {
> if (( 1 ))
> then
> : then
> fi
> true
> }
>
> This is, not to put too fine a point on it, wrong.
But of course the bug is that it doesn't complain about a parse error,
right?
I hope that all syntactically correct strings end with a token of
ENDINPUT in parse_list().
The hunk in exec.c makes loadautofn() treat empty functions in the
same way as execautofn().
Bye
Sven
diff -ru ../z.old/Src/exec.c Src/exec.c
--- ../z.old/Src/exec.c Fri Feb 4 09:53:28 2000
+++ Src/exec.c Fri Feb 4 10:29:34 2000
@@ -3097,6 +3097,8 @@
zerr("%s: function definition file not found", shf->nam, 0);
return 1;
}
+ if (!prog)
+ prog = &dummy_eprog;
PERMALLOC {
shf->funcdef = dupeprog(stripkshdef(prog, shf->nam));
} LASTALLOC;
diff -ru ../z.old/Src/parse.c Src/parse.c
--- ../z.old/Src/parse.c Fri Feb 4 09:53:32 2000
+++ Src/parse.c Fri Feb 4 10:25:35 2000
@@ -357,7 +357,11 @@
incmdpos = 1;
yylex();
ret = par_list();
- if (tok == LEXERR) {
+#if 0
+ if (tok == LEXERR)
+#endif
+ if (tok != ENDINPUT)
+ {
yyerror(0);
return NULL;
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-02-04 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-02-04 9:34 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-02-03 18:30 Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200002040934.KAA22630@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).