From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Infinite loop (bug in wordcode evaluation?)
Date: Mon, 7 Feb 2000 11:25:02 +0100 (MET) [thread overview]
Message-ID: <200002071025.LAA32288@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Fri, 4 Feb 2000 16:31:39 +0000
Bart Schaefer wrote:
> On Feb 4, 10:08am, Sven Wischnowsky wrote:
> } Subject: Re: Infinite loop (bug in wordcode evaluation?)
> }
> } Bart Schaefer wrote:
> }
> } > } The problem is that none of the functions in loop.c check if retflag
> } > } is set and hence don't return.
> } >
> } > I can't find any loop construct in 3.0.7 that produces this behavior,
> } > yet 3.0.7 does not have any of those extra retflag tests in loop.c.
> } >
> } > Does anyone know what else might have changed to cause this problem?
> }
> } Found it. getkey() in zle_main.c now resets `breaks' to the value it had
> } before, so that the new value stored in bin_break() set by the signal
> } handler doesn't make it through to the execution code.
> }
> } Dunno where this comes from, though.
>
> It came from zsh-workers/7038, something to do with making _read_comp
> work correctly.
Yep. One could say that that patch explictly implemented the behaviour
we now consider buggy. Almost. At least it makes a `break' in a signal
handler have no effect if the signal arrives while we are reading with
zle (and the handler for SIGINT has an implicit `break', breaking all
loops).
Hm. If 7038 is still considered to be correct, then my patch is
probably the right supplement for it to make `return' in signal
handlers work. At least I don't see another way out at the moment.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-02-07 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-02-07 10:25 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-02-04 9:08 Sven Wischnowsky
2000-02-04 16:31 ` Bart Schaefer
2000-01-31 12:04 Sven Wischnowsky
2000-02-03 17:40 ` Bart Schaefer
2000-01-30 17:36 Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200002071025.LAA32288@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).