Re: "BUG: empty heap" and problem with _cvs

Re: "BUG: empty heap" and problem with _cvs

[Sven Wischnowsky]

Bart Schaefer wrote:

> } > zagzig<5> cvs <TAB>BUG: empty heap
> } 
> } I can't get the `heap empty' even though I have all debugging macros
> } defined. Damn.
> 
> I can't get it any more, either.
> 
> } Also, I'm not sure why heaps shouldn't be allowed to be empty...
> 
> I think the idea was that zsh shouldn't be pushing a heap onto the
> stack of heaps until it's known that some of the memory is going to
> be used.  It was a way of detecting extraneous pushheap() calls.
> Possibly obsolete now that all stack and heap allocations are made
> explicitly.

Ah, right. And since several parts of the shell have been changed to
be non-copying any more, this may the whole problem...

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: "BUG: empty heap" and problem with _cvs

[Bart Schaefer]

On Feb 28, 10:14am, Sven Wischnowsky wrote:
} Subject: Re: "BUG: empty heap" and problem with _cvs
}
} 
} Bart Schaefer wrote:
} 
} > zagzig<3> compinit 
} > zagzig<4> setopt kshautoload 
} 
} (Hm. Completion fails terribly when kshautoload is set...)

Yup.

} > zagzig<5> cvs <TAB>BUG: empty heap
} 
} I can't get the `heap empty' even though I have all debugging macros
} defined. Damn.

I can't get it any more, either.

} Also, I'm not sure why heaps shouldn't be allowed to be empty...

I think the idea was that zsh shouldn't be pushing a heap onto the
stack of heaps until it's known that some of the memory is going to
be used.  It was a way of detecting extraneous pushheap() calls.
Possibly obsolete now that all stack and heap allocations are made
explicitly.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: "BUG: empty heap" and problem with _cvs

[Sven Wischnowsky]

Bart Schaefer wrote:

> zagzig<3> compinit 
> zagzig<4> setopt kshautoload 
> zagzig<5> cvs <TAB>BUG: empty heap
> BUG: empty heap
> BUG: empty heap
> BUG: empty heap
> BUG: empty heap
> BUG: empty heap
> 
> _requested:192: _requested: function not defined by file
> zagzig<5> cvs
> 
> 
> The fix for _cvs follows, but I don't have a patch for the "empty heap".

(Hm. Completion fails terribly when kshautoload is set...)

I can't get the `heap empty' even though I have all debugging macros
defined. Damn. Also, I'm not sure why heaps shouldn't be allowed to be 
empty...


Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

"BUG: empty heap" and problem with _cvs

[Bart Schaefer]

zagzig<3> compinit 
zagzig<4> setopt kshautoload 
zagzig<5> cvs <TAB>BUG: empty heap
BUG: empty heap
BUG: empty heap
BUG: empty heap
BUG: empty heap
BUG: empty heap

_requested:192: _requested: function not defined by file
zagzig<5> cvs


The fix for _cvs follows, but I don't have a patch for the "empty heap".

Index: Completion/User/_cvs
===================================================================
@@ -656,4 +656,4 @@
 
 # call real _cvs.
 
-_cvs "$@"
+[[ -o kshautoload ]] || _cvs "$@"

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com