From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: `foo=foo; (( foo ))' => infinite recursion
Date: Mon, 13 Mar 2000 10:34:47 +0100 (MET) [thread overview]
Message-ID: <200003130934.KAA16098@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Alexandre Duret-Lutz's message of 09 Mar 2000 21:10:19 +0100
Alexandre Duret-Lutz wrote:
> An easy way to die.
>
> ~ % zsh -f
> phobos% foo=foo; (( foo ))
> zsh: segmentation fault zsh -f
What really irritated me was that getnumvalue() called matheval().
That meant that in cases like the one above $foo could contain any
mathematical expression and that would get evaluated.
The patch makes it take only numbers from $foo (or integer-zero if
there is none). If that is considered to be the wrong idea we have to
find some other way to avoid the endless recusion, I think.
One question: currently it only skips white space at the beginning of
$foo to find the number (btw, all number-formats zsh knows of should
be understood); should we make it skip all non-numeric characters?
Bye
Sven
diff -ru ../z.old/Src/math.c Src/math.c
--- ../z.old/Src/math.c Mon Mar 13 10:18:27 2000
+++ Src/math.c Mon Mar 13 10:29:36 2000
@@ -950,6 +950,78 @@
return (x.type & MN_FLOAT) ? (zlong)x.u.d : x.u.l;
}
+/**/
+mod_export mnumber
+mathnumber(char *s)
+{
+ mnumber ret;
+
+ ret.type = MN_INTEGER;
+
+ while (*s) {
+ switch (*s++) {
+ case '[':
+ {
+ int base = zstrtol(s, &s, 10);
+
+ if (*s == ']')
+ s++;
+ ret.u.l = zstrtol(s, &s, base);
+ return ret;
+ }
+ case ' ':
+ case '\t':
+ case '\n':
+ break;
+ case '0':
+ if (*s == 'x' || *s == 'X') {
+ /* Should we set lastbase here? */
+ ret.u.l = zstrtol(++s, &s, 16);
+ return ret;
+ }
+ /* Fall through! */
+ default:
+ if (idigit(*--s) || *s == '.') {
+ char *nptr;
+#ifdef USE_LOCALE
+ char *prev_locale;
+#endif
+ for (nptr = s; idigit(*nptr); nptr++);
+
+ if (*nptr == '.' || *nptr == 'e' || *nptr == 'E') {
+ /* it's a float */
+ ret.type = MN_FLOAT;
+#ifdef USE_LOCALE
+ prev_locale = setlocale(LC_NUMERIC, NULL);
+ setlocale(LC_NUMERIC, "POSIX");
+#endif
+ ret.u.d = strtod(s, &nptr);
+#ifdef USE_LOCALE
+ setlocale(LC_NUMERIC, prev_locale);
+#endif
+ if (s == nptr || *nptr == '.')
+ goto end;
+ s = nptr;
+ } else {
+ /* it's an integer */
+ ret.u.l = zstrtol(s, &s, 10);
+
+ if (*s == '#')
+ ret.u.l = zstrtol(++s, &s, ret.u.l);
+ }
+ return ret;
+ }
+ goto end;
+ }
+ }
+ end:
+
+ ret.type = MN_INTEGER;
+ ret.u.l = 0;
+
+ return ret;
+}
+
/*
* Make sure we have an operator or an operand, whatever is expected.
* For this purpose, unary operators constitute part of an operand.
diff -ru ../z.old/Src/params.c Src/params.c
--- ../z.old/Src/params.c Mon Mar 13 10:18:27 2000
+++ Src/params.c Mon Mar 13 10:29:36 2000
@@ -1420,7 +1420,7 @@
mn.type = MN_FLOAT;
mn.u.d = v->pm->gets.ffn(v->pm);
} else
- return matheval(getstrvalue(v));
+ return mathnumber(getstrvalue(v));
return mn;
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-03-13 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-03-13 9:34 Sven Wischnowsky [this message]
2000-03-13 16:05 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-03-09 20:10 Alexandre Duret-Lutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200003130934.KAA16098@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).