From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: dot file completion
Date: Fri, 24 Mar 2000 12:44:48 +0100 (MET) [thread overview]
Message-ID: <200003241144.MAA25838@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Tanaka Akira's message of 24 Mar 2000 19:59:07 +0900
Tanaka Akira wrote:
> Z(2):akr@is27e1u11% Src/zsh -f
> is27e1u11% bindkey -e; autoload -U compinit; compinit -D; compdef _tst tst
> is27e1u11% mkdir z
> is27e1u11% touch z/.abc
> is27e1u11% _tst () { _files -g .abc }
> is27e1u11% tst z/.<TAB>
> ./ ..abc .abc
>
> `..abc' shouldn't be completed.
>
> And `./' too?
Mostly a problem with getting the patterns -- there was a empty string
in the $pats array. And then we shouldn't prepend a dot to patterns
already starting with one.
Note: with Tanaka's example doing `tst ./.<TAB>' when there is no file
`.abc' in the current directory will complete to `./.abc' nonetheless.
In some cases this may be interesting to have, but I guess in most
cases not, right? If anyone now answers `yes', I'll change it...
Bye
Sven
diff -ru ../z.old/Completion/Core/_path_files Completion/Core/_path_files
--- ../z.old/Completion/Core/_path_files Fri Mar 24 12:23:16 2000
+++ Completion/Core/_path_files Fri Mar 24 12:36:57 2000
@@ -30,6 +30,7 @@
else
pats=( "${(@)=${(@M)tmp1:#-g*}#-g}" )
fi
+pats=( "${(@)pats:# #}" )
if (( $#prepaths )); then
tmp1="${prepaths[2]}"
@@ -269,7 +270,7 @@
fi
else
if [[ ! -o globdots && "$PREFIX" = .* ]]; then
- tmp1=( ${^tmp1}${skipped}${^~pats} ${^tmp1}${skipped}.${^~pats} )
+ tmp1=( ${^tmp1}${skipped}${^~pats} ${^tmp1}${skipped}.${^~pats:#.*} )
else
tmp1=( ${^tmp1}${skipped}${^~pats} )
fi
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-03-24 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-03-24 11:44 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-03-24 10:59 Tanaka Akira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200003241144.MAA25838@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).