* PATCH: Re: Selection won't start
@ 2000-04-05 10:48 Sven Wischnowsky
0 siblings, 0 replies; only message in thread
From: Sven Wischnowsky @ 2000-04-05 10:48 UTC (permalink / raw)
To: zsh-workers
Peter Stephenson wrote:
> Running zsh -f and loading completion, then using these styles:
>
> zstyle ':completion:*' completer _oldlist _complete _approximate
> zstyle ':completion:*' max-errors 2 numeric
> zstyle ':completion:*' menu select=5
>
> menu selection doesn't come into effect (with AUTOMENU) until I explicitly
> set SELECTMIN, after which it seems to be following the value of SELECTMIN,
> not the style. I also need to load zsh/complist explicitly as well. It
> doesn't seem to be dependent on the order of the initialization (I wouldn't
> expect it to be). I can't see offhand how it's supposed to work, so I
> don't know if this is just me getting something wrong. I tried with both
> filename completion and option completion. I deliberately don't have
> list-colors set, but in any case it isn't necessary for SELECTMIN to work.
This was all caused by the wrong test in _main_complete. I must have
accidentally deleted the `sel' sometime. Dunno.
> (I just noticed how incomprehensible to beginners that is. AUTOMENU is an
> option, SELECTMIN is a parameter, list-colors is a style, zsh/complist is a
> module... I suppose you just have to be here when it's happening.)
That's why I made it load complist automatically and so on. One only
needs to use the style.
There are still some other options that don't have equivalent styles, though.
> Also, _zmodload is now failing to remove the `.so' from the ends of
> modules.
A small thinko in _files.
Bye
Sven
Index: Completion/Core/_files
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_files,v
retrieving revision 1.3
diff -u -r1.3 _files
--- Completion/Core/_files 2000/04/03 15:27:14 1.3
+++ Completion/Core/_files 2000/04/05 10:44:48
@@ -6,7 +6,7 @@
'/=tmp' 'f=tmp' 'g+:-=tmp' q n 1 2 P: S: r: R: W: X+: M+: F: J+: V+:
type="${(@j::M)${(@)tmp#-}#?}"
-(( $tmp[(I)-g*] )) && glob="${(j: :)${(M)tmp:#-g*}#-g}"
+(( $tmp[(I)-g*] )) && glob="${(j: :)${(@M)tmp:#-g*}#-g}"
ign=$opts[(I)-F]
if (( ign )); then
ign=( $=opts[ign+1] )
Index: Completion/Core/_main_complete
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_main_complete,v
retrieving revision 1.3
diff -u -r1.3 _main_complete
--- Completion/Core/_main_complete 2000/04/03 13:13:02 1.3
+++ Completion/Core/_main_complete 2000/04/05 10:44:48
@@ -140,7 +140,7 @@
else
sel=( "${(@M)_menu_style:#select*}" )
- if (( $# )); then
+ if (( $#sel )); then
local min=9999999 i num
for i in "$sel[@]"; do
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2000-04-05 10:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-04-05 10:48 PATCH: Re: Selection won't start Sven Wischnowsky
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).