zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: _oldlist and _complete_help oddities
Date: Tue, 11 Apr 2000 12:40:51 +0200 (MET DST)	[thread overview]
Message-ID: <200004111040.MAA04412@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Andrej Borsenkow"'s message of Tue, 11 Apr 2000 14:33:19 +0400


Andrej Borsenkow wrote:

> bor@itsrm2% ls <TAB>
> bor@itsrm2% ls
> ...
> bor@itsrm2% ls ^Xh
> Completing file
> CVS/            ChangeLog       ChangeLog.3.0   Completion/     Config/
> ...
> 
> List is not redrawn.

Oops. _oldlist should not only ignore the list from _complete_help, it 
should also avoid to re-use an old list if _complete_help is called.

And now the tests there really make me think that there has to be a
cleaner way...

Bye
 Sven

Index: Completion/Core/_oldlist
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_oldlist,v
retrieving revision 1.3
diff -u -r1.3 _oldlist
--- Completion/Core/_oldlist	2000/04/11 09:40:13	1.3
+++ Completion/Core/_oldlist	2000/04/11 10:39:22
@@ -14,7 +14,7 @@
 # completer named by the oldlist_list key.
 
 if [[ -n $compstate[old_list] && $list != never &&
-      $LASTWIDGET != _complete_help ]]; then
+      $LASTWIDGET != _complete_help && $WIDGET != _complete_help ]]; then
   if [[ $WIDGET = *list* && ( $list = always || $list != shown ) ]]; then
     compstate[old_list]=keep
     return 0
@@ -35,7 +35,7 @@
 # existing list (even if it was generated by another widget).
 
 if [[ -z $compstate[old_insert] && -n $compstate[old_list] &&
-      $LASTWIDGET != _complete_help ]]; then
+      $LASTWIDGET != _complete_help && $WIDGET != _complete_help ]]; then
   compstate[old_list]=keep
   return 0
 elif [[ $WIDGET = *complete(|-prefix|-word) ]] &&

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


             reply	other threads:[~2000-04-11 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-04-11 10:40 Sven Wischnowsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2000-04-11 10:33 Andrej Borsenkow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200004111040.MAA04412@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).