PATCH: Re: Question

[Sven Wischnowsky <wischnow@informatik.hu-berlin.de>]

Peter Stephenson wrote:

> Sven Wischnowsky wrote:
> > Currently, if a completion list is too long, the completion system
> > asks if onw wants to see all <n> matches. This is not only ugly in
> > cases like _complete_help with styles-output -- it askes if one wants
> > to see all `0' matches.
> > 
> > Should we change it to mention the number of lines needed? I think it
> > would always be more interesting.
> 
> Yes, it would.  I suppose this is too deep to be able to use a style.

Yes, it is. In fact everything about this was always hard-coded,
including the prompt itself. Changing that would be easy, but is it
worth it?

Bye
 Sven

Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.3
diff -u -r1.3 compresult.c
--- Src/Zle/compresult.c	2000/04/10 08:06:39	1.3
+++ Src/Zle/compresult.c	2000/04/12 08:27:38
@@ -1585,8 +1585,8 @@
 	 (!complistmax && listdat.nlines >= lines))) {
 	int qup;
 	zsetterm();
-	qup = printfmt("zsh: do you wish to see all %n possibilities? ",
-		       listdat.nlist, 1, 1);
+	qup = printfmt("zsh: do you wish to see all %n lines? ",
+		       listdat.nlines, 1, 1);
 	fflush(shout);
 	if (getzlequery() != 'y') {
 	    if (clearflag) {
Index: Src/Zle/zle_tricky.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_tricky.c,v
retrieving revision 1.3
diff -u -r1.3 zle_tricky.c
--- Src/Zle/zle_tricky.c	2000/04/10 09:29:09	1.3
+++ Src/Zle/zle_tricky.c	2000/04/12 08:27:38
@@ -1991,8 +1991,8 @@
 	int qup;
 
 	zsetterm();
-	qup = printfmt("zsh: do you wish to see all %n possibilities? ",
-		       num, 1, 1);
+	qup = printfmt("zsh: do you wish to see all %n lines? ",
+		       nlines, 1, 1);
 	fflush(shout);
 	if (getzlequery() != 'y') {
 	    if (clearflag) {

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de