Re: dev-22 compile problem

Re: dev-22 compile problem

[Jason Price]

> I've sent a patch for that (10726), but maybe you're not on the list?
> Sorry.

I'm on it, I just havn't been a developer... :-)

> I would be grateful if you could tell us/me if this fixes it because I 
> don't have access to a NIS+ box anymore. Thanks!
> -    if (object->zo_data.objdata_u.en_data.en_cols.en_cols >= 6) {
> +    if (object->zo_data.objdata_u.en_data.en_cols.en_cols_len >= 6) {

I was able to compile/install it, and 'make test' ran successfully.

I havn't had a chance to push it yet, but we'll see what we can do.

Jason

-- 
Faith is not a matter of questions.      Jason Price
Faith is a matter of answers.            jprice@gatech.edu
More to the point, one answer:           Theta Xi, Beta Alpha, 449
"Yes, Lord."

Re: 3.1.6-dev-22

[Bart Schaefer]

On Apr 9,  7:54pm, Peter Stephenson wrote:
} Subject: 3.1.6-dev-22
}
} I have uploaded
}   ftp://ftp.zsh.org/zsh/development/zsh-3.1.6-dev-22.tar.gz
} which is also tagged in the CVS archive as zsh-3_1_6-dev-22 .
} (At least, the message says it worked, although I can't see it there yet.)

About an hour later now, and it still isn't there yet.

} It's now time for anybody to suggest things which need doing (and which are
} likely actually to get done) before 3.1.7, else I shall start producing
} pre-releases.

I've sent a number of messages asking about potential changes, to which
there have been no replies or at least no decision (e.g., 10346, users/3013,
users/2973, others).  Does Sven have any outstanding issues with completion?

} I would appreciate any opinions on whether fixing
} `export' to work locally in functions is a good idea.  We can now do export
} -g to refer to the global variable --- but it's been the way it is for so
} long that maybe a change would cause trouble.  It's not suitable to have an
} option for this.

I think it should work like ksh in sh/ksh emulation modes, but otherwise I
think the current behavior is OK.  That isn't exactly the same as having an
option; do you believe that also to be unsuitable?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: 3.1.6-dev-22

[Peter Stephenson]

I forgot about this...

"Bart Schaefer" wrote:
> } I would appreciate any opinions on whether fixing
> } `export' to work locally in functions is a good idea.  We can now do export
> } -g to refer to the global variable --- but it's been the way it is for so
> } long that maybe a change would cause trouble.  It's not suitable to have an
> } option for this.
> 
> I think it should work like ksh in sh/ksh emulation modes, but otherwise I
> think the current behavior is OK.  That isn't exactly the same as having an
> option; do you believe that also to be unsuitable?

Well, up to now every change in emulation has been mirrored in some
option.  It's not strictly necessary, but it does make things a lot
neater.  Sooner or later someone's going to want the feature and find they
can only do it by setting two gross of options.

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@CambridgeSiliconRadio.com
Web: http://www.pwstephenson.fsnet.co.uk

dev-22 compile problem

[Jason Price]

I have been trying to compile dev-22 on Solaris 2.7 with both gcc 2.81, and
gcc 2.95.2, and failing in the same place on both.  

It's a strait gtar -xzf zsh*.gz ; cd zsh<tab> ; ./configure ; make.

The error I'm getting is:

gcc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o hashtable.o hashtable.c
hashtable.c: In function `add_userdir':
hashtable.c:1191: structure has no member named `en_cols'
make[2]: *** [hashtable.o] Error 1
make[2]: Leaving directory `/export/home/jprice/programs/zsh/zsh-3.1.6-dev-22/Src'
make[1]: *** [modobjs] Error 2
make[1]: Leaving directory `/export/home/jprice/programs/zsh/zsh-3.1.6-dev-22/Src'
make: *** [all] Error 1

If I need to give more info, please let me know.

Solaris 2.7, 128 m ram, ultra 1, 167 MHz.  To the best of my knowledge,
it's a strait 2.7 machine.  I havn't torched it, and re-installed to verify
it though...

Jason

-- 
Faith is not a matter of questions.      Jason Price
Faith is a matter of answers.            jprice@gatech.edu
More to the point, one answer:           Theta Xi, Beta Alpha, 449
"Yes, Lord."

Re: dev-22 compile problem

[Bart Schaefer]

On Apr 12,  4:29pm, Jason Price wrote:
> Subject: dev-22 compile problem
> 
> hashtable.c:1191: structure has no member named `en_cols'

Apparently no one else is building zsh with HAVE_NIS_PLUS.

Try deleting half of the .en_cols.en_cols on line 1191 of hashtable.c.

Re: dev-22 compile problem

[Jason Price]

On Wed, Apr 12, 2000 at 05:15:28PM -0700, Bart Schaefer wrote:
> On Apr 12,  4:29pm, Jason Price wrote:
> > Subject: dev-22 compile problem
> > hashtable.c:1191: structure has no member named `en_cols'
> Apparently no one else is building zsh with HAVE_NIS_PLUS.
> Try deleting half of the .en_cols.en_cols on line 1191 of hashtable.c.

The line now looks like:

    if (object->zo_data.objdata_u.en_data.en_cols >= 6) {

As opposed to:

    if (object->zo_data.objdata_u.en_data.en_cols.en_cols >= 6) {

And the error returned is:

gcc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -Wall
-Wno-implicit -Wmissing-prototypes -O2  -o hashtable.o hashtable.c
hashtable.c: In function `add_userdir':
hashtable.c:1191: invalid operands to binary >=
make[2]: *** [hashtable.o] Error 1
make[2]: Leaving directory `/export/home/jprice/programs/zsh/zsh-3.1.6-dev-22/Src'
make[1]: *** [modobjs] Error 2
make[1]: Leaving directory `/export/home/jprice/programs/zsh/zsh-3.1.6-dev-22/Src'
make: *** [all] Error 1

Thanks;
Jason

-- 
Faith is not a matter of questions.      Jason Price
Faith is a matter of answers.            jprice@gatech.edu
More to the point, one answer:           Theta Xi, Beta Alpha, 449
"Yes, Lord."

Re: dev-22 compile problem

[Geoff Wing]

Jason Price <jprice@cyberbuzz.gatech.edu> typed:
:On Wed, Apr 12, 2000 at 05:15:28PM -0700, Bart Schaefer wrote:
:> On Apr 12,  4:29pm, Jason Price wrote:
:> > Subject: dev-22 compile problem
:> > hashtable.c:1191: structure has no member named `en_cols'
:> Apparently no one else is building zsh with HAVE_NIS_PLUS.
:> Try deleting half of the .en_cols.en_cols on line 1191 of hashtable.c.
:The line now looks like:
:    if (object->zo_data.objdata_u.en_data.en_cols >= 6) {
:As opposed to:
:    if (object->zo_data.objdata_u.en_data.en_cols.en_cols >= 6) {
:And the error returned is:

I guess it should be something like:

 if (object->zo_data.objdata_u.en_data.en_cols.en_cols_len >= 6) {

The check with 6 to make sure there are 6+ columns because we later access
the 6th column.


Quick look a Sun docs (docs.sun.com):

union {
	struct directory_obj     di_data;
	struct group_obj         gr_data;
	struct table_obj         ta_data;
	struct entry_obj         en_data;
	struct link_obj          li_data;
	struct {
		u_int              po_data_len;
		char               * po_data_val;
	} po_data;
} objdata_u;

struct entry_col {
	u_long     ec_flags;
	struct {
		u_int      ec_value_len;
		char       * ec_value_val;
	} ec_value;
}
typedef struct entry_col entry_col;

struct entry_obj {
	char       * en_type;
	struct {
		u_int      en_cols_len;
		entry_col * en_cols_val;
	} en_cols;
}


-- 
Geoff Wing : <gcw@pobox.com>     Work URL: http://www.primenet.com.au/
Rxvt Stuff : <gcw@rxvt.org>      Ego URL : http://pobox.com/~gcw/
Zsh Stuff  : <gcw@zsh.org>       Phone   : (Australia) 0413 431 874