From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: partial word completion
Date: Tue, 18 Apr 2000 09:06:12 +0200 (MET DST) [thread overview]
Message-ID: <200004180706.JAA18756@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Felix Rosencrantz's message of Mon, 17 Apr 2000 18:20:06 -0700 (PDT)
Felix Rosencrantz wrote:
> Zsh seems to crash now with this patch. The third parameter to sub_join()
> is NULL, which causes the crash. Here's the stack trace:
>
> ...
>
> Sorry not to provide a simple test case. If you need that I can investigate
> a little more. The error happened in a directory with many files, and
> some simple pruning didn't uncover the error.
Ouch. That was something between a typo and a thinko.
Better check the variable that will be used...
Bye
Sven
Index: Src/Zle/compmatch.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compmatch.c,v
retrieving revision 1.5
diff -u -r1.5 compmatch.c
--- Src/Zle/compmatch.c 2000/04/17 07:56:25 1.5
+++ Src/Zle/compmatch.c 2000/04/18 07:04:09
@@ -1893,10 +1893,10 @@
for (tt = o;
(to = tt->next) &&
!cmp_anchors(tn, to, 1); tt = to);
- if (tt)
+ if (to)
break;
}
- if (tt) {
+ if (to) {
diff = sub_join(n, o, to, 1);
if (po)
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-04-18 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-04-18 7:06 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-04-18 1:20 Felix Rosencrantz
2000-04-17 7:55 Sven Wischnowsky
2000-04-03 12:17 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200004180706.JAA18756@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).