From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Some problems with list scrolling and menu selection
Date: Thu, 20 Apr 2000 13:00:30 +0200 (MET DST) [thread overview]
Message-ID: <200004201100.NAA28705@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Andrej Borsenkow"'s message of Thu, 20 Apr 2000 13:35:58 +0400
Andrej Borsenkow wrote:
> 1. The default for starting menu selection is less than user friendly.
> Normally, menu selection is started on the second TAB (assuming more or
> less standard config; zstyle output follows). With list scrolling TAB
> first pages to the end of list and only then starts selection. I think,
> TAB should behave the same way here as well. Probably, "least surprise"
> for user would be, when TAB in list scrolling jumps to the first shown
> match (and not to the very first item in the list). Consider usage - you
> first find needed page and then select needed item there.
Hm, `less than user friendly'? See also below: the reference to
10816. Currently, the listing code is intentionally separated from the
menu-selection code to make the listing code (including scrolling)
work on (almost) every terminal.
For the jump-into-menu-selection-now: I'm not sure if this is really
more user friendly. And remember, that any widget without special
meaning stops listing and is executed right away, so:
bindkey -M listscroll '^I' .menu-select
Is that enough? If we document it?
> 2. There are problems with scrolling back in menu selection. Try GNU
> diff (with verbose on). I did it on dtterm from TriTeal TED 4.2 with
> 24x80 size.
>
> ...
>
> Note, that the line just under the prompt disappears.
A nasty off-by-one error when displaying matches with line-oriented
display strings. You probably guessed that.
> 3. Is it possible to retain current Zle line (prompt) at the top when
> listing completions? Like menu selection does it. I find it somewhat
> confusing as it is.
>
> 4. And, of course, scrolling back in completion listing :-)
Have you read 10816?
Bye
Sven
Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.4
diff -u -r1.4 complist.c
--- Src/Zle/complist.c 2000/04/19 06:49:37 1.4
+++ Src/Zle/complist.c 2000/04/20 10:53:45
@@ -1122,21 +1122,12 @@
n = lastn;
nl = lastnl;
lastused = 1;
+ pnl = 0;
} else
p = g->matches;
for (; (m = *p); p++) {
if (m->disp && (m->flags & CMF_DISPLINE)) {
- if (!lasttype && ml >= mlbeg) {
- lasttype = 2;
- lastg = g;
- lastbeg = mlbeg;
- lastml = ml;
- lastp = p;
- lastn = n;
- lastnl = nl;
- lastused = 1;
- }
if (pnl) {
if (dolistnl(ml) && compprintnl(ml))
goto end;
@@ -1147,6 +1138,16 @@
if (tccan(TCCLEAREOD))
tcout(TCCLEAREOD);
}
+ }
+ if (!lasttype && ml >= mlbeg) {
+ lasttype = 2;
+ lastg = g;
+ lastbeg = mlbeg;
+ lastml = ml;
+ lastp = p;
+ lastn = n;
+ lastnl = nl;
+ lastused = 1;
}
if (mfirstl < 0)
mfirstl = ml;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-04-20 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-04-20 11:00 Sven Wischnowsky [this message]
2000-04-20 12:03 ` Andrej Borsenkow
-- strict thread matches above, loose matches on Subject: below --
2000-04-20 12:14 Sven Wischnowsky
2000-04-20 9:35 Andrej Borsenkow
2000-04-20 9:37 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200004201100.NAA28705@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).