Re: PATCH: Re: Patches committed

Re: PATCH: Re: Patches committed

[Sven Wischnowsky]

Bart Schaefer wrote:

> On Apr 26,  3:12pm, Sven Wischnowsky wrote:
> } 
> } Adam Spiers wrote:
> } 
> } > % echo <M-/>
> } > _tags:58: no matches found: (|*-)argument-* (|*-)option-* values
> } 
> } I guess that was your weird option setting, err... that was due to
> } missing standard option initialisation in _h_c_w. Remember
> } _complete_help?
> 
> Did anyone see my remark about this in 10897?

Yes, but in this case... we never unsetopt localoptions.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: PATCH: Re: Patches committed

[Sven Wischnowsky]

Adam Spiers wrote:

> Sven Wischnowsky (wischnow@informatik.hu-berlin.de) wrote:
> > I guess that was your weird option setting, err... 
> 
> :-)  Which of my option choices are unusual, out of curiosity?

It was globsubsts and shwordsplit again, especially the former.

I didn't want to say that they are unusual. Really ;-)

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: PATCH: Re: Patches committed

[Adam Spiers]

Sven Wischnowsky (wischnow@informatik.hu-berlin.de) wrote:
> I guess that was your weird option setting, err... 

:-)  Which of my option choices are unusual, out of curiosity?

> Does this help?

Yes, thanks.

Re: PATCH: Re: Patches committed

[Bart Schaefer]

On Apr 26,  3:12pm, Sven Wischnowsky wrote:
} 
} Adam Spiers wrote:
} 
} > % echo <M-/>
} > _tags:58: no matches found: (|*-)argument-* (|*-)option-* values
} 
} I guess that was your weird option setting, err... that was due to
} missing standard option initialisation in _h_c_w. Remember
} _complete_help?

Did anyone see my remark about this in 10897?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

PATCH: Re: Patches committed

[Sven Wischnowsky]

Adam Spiers wrote:

> Sven Wischnowsky (wischnow@informatik.hu-berlin.de) wrote:
> > Just to let you know, I just committed Tanaka's 10890 and 10885 and
> > Adam's 10892.
> 
> Cool, thanks.
> 
> > I haven't commited Felix' 10893 or 10894:
> 
> I don't know whether this is related, but h-c-w seems to have broken:
> 
> % echo <M-/>
> _tags:58: no matches found: (|*-)argument-* (|*-)option-* values

I guess that was your weird option setting, err... that was due to
missing standard option initialisation in _h_c_w. Remember
_complete_help?

Does this help?

Bye
 Sven

Index: Completion/Commands/_bash_completions
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Commands/_bash_completions,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 _bash_completions
--- Completion/Commands/_bash_completions	1999/10/26 15:36:11	1.1.1.2
+++ Completion/Commands/_bash_completions	2000/04/26 13:10:36
@@ -25,6 +25,9 @@
 # that will not have been overridden, so you should add '~' to the
 # list of keys at the top of the for-loop.
 
+setopt localoptions nullglob rcexpandparam extendedglob
+unsetopt markdirs globsubst shwordsplit nounset ksharrays
+
 local key=$KEYS[-1]
 
 case $key in
@@ -34,7 +37,7 @@
        ;;
   '@') _main_complete _hosts
        ;;
-  '/') _files
+  '/') _main_complete _files
        ;;
   '~') _main_complete _users
        ;;
Index: Completion/Commands/_history_complete_word
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Commands/_history_complete_word,v
retrieving revision 1.2
diff -u -r1.2 _history_complete_word
--- Completion/Commands/_history_complete_word	2000/04/01 20:43:43	1.2
+++ Completion/Commands/_history_complete_word	2000/04/26 13:10:37
@@ -17,6 +17,9 @@
 #
 
 _history_complete_word () {
+  setopt localoptions nullglob rcexpandparam extendedglob
+  unsetopt markdirs globsubst shwordsplit nounset ksharrays
+
   local expl direction stop
 
   if [[ $WIDGET = *newer ]]; then

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de