From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: bugfixes for _rpm and _hash
Date: Thu, 27 Apr 2000 09:18:08 +0200 (MET DST) [thread overview]
Message-ID: <200004270718.JAA11049@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Adam Spiers's message of Wed, 26 Apr 2000 18:49:05 +0100
Adam Spiers wrote:
> Adam Spiers (adam@spiers.net) wrote:
> > Bart Schaefer (schaefer@candle.brasslantern.com) wrote:
> > > Take that "$expl[@]" out of there, you don't need it and it's ultimately
> > > causing an empty string as an argument to _files.
> >
> > Ahah. In that case is _hash wrong? It has
> >
> > _wanted -C value values expl 'executable file' _files "$expl[@]" -g '*(-*)'
> >
> > which seems to exhibit the same problem.
>
> As soon as someone confirms this, I'll apply this patch, which makes
> things work as expected.
I don't know rpm, so I can only talk about the other stuff.
It is ok, but you don't need to use _wanted for _files if you don't
need to change the context (i.e. if you don't need to give the -C
option to _wanted as _hash does). _files is one of the functions that
does everything you need (like the other type-of-matches functions,
e.b. _pids, _options and so on).
About the $expl[@] stuff... sorry for that, I think I should take the
time to look at all the completion functions again to see if such bugs
are somewhere else, too. Sigh.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-04-27 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-04-27 7:18 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-04-26 16:37 PATCH: bugfixes for _rpm Adam Spiers
2000-04-26 17:23 ` Bart Schaefer
2000-04-26 17:35 ` Adam Spiers
2000-04-26 17:49 ` PATCH: bugfixes for _rpm and _hash Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200004270718.JAA11049@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).