* Re: PATCH: RE: _make error
@ 2000-04-27 12:42 Sven Wischnowsky
0 siblings, 0 replies; 2+ messages in thread
From: Sven Wischnowsky @ 2000-04-27 12:42 UTC (permalink / raw)
To: zsh-workers
Andrej Borsenkow wrote:
> > In Zsh top level directory (gmake is GNU make)
> >
> > sudo gmake install.moTAB
> >
> > resulted in (long long - already scrolled away)
> >
> > ........
> >
> > make: Fatal error: don't know how to make .PHONY (bu42).
> > dules
>
> It called ``make'' instead of $words[1]. Patch attached because of line
> length as usual.
The patch below contains Andrej's change and some more from me.
It should *at least* use _call. And I'm *very* tempted to add a style
to keep it from calling make even when it's a GNU make. Somehow I was
asleep when this was added, it seems, although I remember that there
was a lot of discussion.
Heck, doing `make <TAB>' just made it run config.status or
something. That's *completely* unacceptable.
Bye
Sven
Index: Completion/User/_make
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/User/_make,v
retrieving revision 1.6
diff -u -r1.6 _make
--- Completion/User/_make 2000/04/25 04:50:53 1.6
+++ Completion/User/_make 2000/04/27 12:41:35
@@ -33,7 +33,7 @@
if [[ -n "$file" ]] && _tags targets; then
if [[ -n "$_is_gnu[$words[1]]" ]]; then
- tmp=( $(make -nsp --no-print-directory -f "$file" .PHONY | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
+ tmp=( $(_call targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
else
tmp=(
$(awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* PATCH: RE: _make error
2000-04-27 12:21 Andrej Borsenkow
@ 2000-04-27 12:29 ` Andrej Borsenkow
0 siblings, 0 replies; 2+ messages in thread
From: Andrej Borsenkow @ 2000-04-27 12:29 UTC (permalink / raw)
To: ZSH workers mailing list
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
>
> In Zsh top level directory (gmake is GNU make)
>
> sudo gmake install.moTAB
>
> resulted in (long long - already scrolled away)
>
> ........
>
> make: Fatal error: don't know how to make .PHONY (bu42).
> dules
It called ``make'' instead of $words[1]. Patch attached because of line
length as usual.
-andrej
[-- Attachment #2: _make.diff --]
[-- Type: application/octet-stream, Size: 546 bytes --]
--- Completion/User/_make.org Thu Apr 27 16:27:05 2000
+++ Completion/User/_make Thu Apr 27 16:26:41 2000
@@ -33,7 +33,7 @@
if [[ -n "$file" ]] && _tags targets; then
if [[ -n "$_is_gnu[$words[1]]" ]]; then
- tmp=( $(make -nsp --no-print-directory -f "$file" .PHONY | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
+ tmp=( $("$words[1]" -nsp --no-print-directory -f "$file" .PHONY | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
else
tmp=(
$(awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-04-27 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-04-27 12:42 PATCH: RE: _make error Sven Wischnowsky
-- strict thread matches above, loose matches on Subject: below --
2000-04-27 12:21 Andrej Borsenkow
2000-04-27 12:29 ` PATCH: " Andrej Borsenkow
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).