From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Re: History bug (Re: Completion debugging)
Date: Wed, 3 May 2000 09:07:49 +0200 (MET DST) [thread overview]
Message-ID: <200005030707.JAA06994@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Sun, 30 Apr 2000 09:31:16 +0000
Bart Schaefer wrote:
> Look at this snippet of "history" output:
>
> 21 cd zsh-3.1.6
> 22 setup_compinit
> 24 emacs /tmp/zsh149find1 ;: find\ -
> 24 history
> 25 emacs /tmp/zsh149find1 ;: find\ -
> 26 history
> 28 emacs /tmp/zsh149find2 ;: find\
> 29 emacs /tmp/zsh149echo3 ;: echo\ foo\
> 29 history
> 30 reload _complete_debug
> 32 emacs /tmp/zsh149find4 ;: 'find -'
> 32 history
>
> Why are there two of numbers 24, 29 and 32? In each case, the first of the
> two was inserted by calling "print -s ..." during completion. Apparently
> that doesn't work very well.
Of course this isn't only in completion, but in every widget.
The problem is that the history number for the currently edited line
is `reserved' and the `print -s' makes it be used. The patch below is
the simplest solution I can think of.
Bye
Sven
Index: Src/builtin.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/builtin.c,v
retrieving revision 1.12
diff -u -r1.12 builtin.c
--- Src/builtin.c 2000/05/02 15:52:44 1.12
+++ Src/builtin.c 2000/05/03 07:07:17
@@ -2777,7 +2777,7 @@
int nwords = 0, nlen, iwords;
char **pargs = args;
- ent = prepnexthistent(++curhist);
+ ent = prepnexthistent(zleactive ? curhist++ : ++curhist);
while (*pargs++)
nwords++;
if ((ent->nwords = nwords)) {
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-05-03 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-03 7:07 Sven Wischnowsky [this message]
2000-05-03 16:57 ` Bart Schaefer
2000-05-04 11:40 Sven Wischnowsky
2000-05-04 15:34 Sven Wischnowsky
2000-05-04 17:39 ` Bart Schaefer
2000-05-04 20:55 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200005030707.JAA06994@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).