From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Re: BUG: jobs -d causes core dump
Date: Fri, 5 May 2000 09:17:32 +0200 (MET DST) [thread overview]
Message-ID: <200005050717.JAA21361@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Felix Rosencrantz's message of Thu, 4 May 2000 22:16:45 -0700 (PDT)
Felix Rosencrantz wrote:
> When I attempt to run "jobs -l -d" I get a core dump, with the following
> stack trace.
>
> I think the problem occurs when there is a job in the background that was
> started in the current directory. It seems like the pathname in the Job
> structure is a NULL pointer at that time.
Right. Saves us lots of unnecessary dups or copies.
Bye
Sven
Index: Src/jobs.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/jobs.c,v
retrieving revision 1.2
diff -u -r1.2 jobs.c
--- Src/jobs.c 2000/04/01 20:49:48 1.2
+++ Src/jobs.c 2000/05/05 07:17:13
@@ -734,7 +734,7 @@
if ((lng & 4) || (interact && job == thisjob &&
jn->pwd && strcmp(jn->pwd, pwd))) {
fprintf(shout, "(pwd %s: ", (lng & 4) ? "" : "now");
- fprintdir((lng & 4) ? jn->pwd : pwd, shout);
+ fprintdir(((lng & 4) && jn->pwd) ? jn->pwd : pwd, shout);
fprintf(shout, ")\n");
fflush(shout);
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
reply other threads:[~2000-05-05 7:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200005050717.JAA21361@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).