From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH (?): Re: suspend while loop.
Date: Fri, 19 May 2000 09:43:22 +0200 (MET DST) [thread overview]
Message-ID: <200005190743.JAA05852@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Thu, 18 May 2000 16:53:54 +0000
Bart Schaefer wrote:
> ...
>
> It's particularly ugly that you can't ^C out of the loop after the ^Z.
> The shell should not hang uninterrupibly unless the user has really
> wrapped a figurative rope around its figurative neck.
Yep, that's what I was thinking (more or less ;-).
> Does anyone see any problems with the following compromise patch?
It's at least a whole lot better than the previous state.
> ...
>
> The thing that most worries me is that zread() can invoke zle, which can
> invoke shell functions, which ....
No, it only uses getkey() which doesn't call functions. It's just a
read-one-char that works while zle is active. But it should be
possible to avoid the child_unblock() when `izle != 0', I think.
What I was worried about are complicated jobs with loops and
suspending, but the job-control-tests still work.
> Another question is, is there a more generic way to do this that covers all
> builtin commands and not just `read'? Or is `read' really the only one
> that needs it?
I can't think of another one right now. We only have to handle
builtins that can potentially block indefinitely, right? (vared comes
to mind, but that can't be used in such a pipe...)
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-05-19 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-19 7:43 Sven Wischnowsky [this message]
2000-05-19 8:30 ` Bart Schaefer
2000-05-19 14:49 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-05-18 8:37 Sven Wischnowsky
2000-05-18 16:53 ` PATCH (?): " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200005190743.JAA05852@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).