Re: PATCH: faster filenames

[Sven Wischnowsky <wischnow@informatik.hu-berlin.de>]

Peter Stephenson wrote:

> > Here is the first patch to make _path_files faster.
> 
> % cd ~/src/zsh/Src
> % zsh -f
> % autoload -U compinit
> % compinit -D
> % zstyle ':completion:*' menu select=1
> % setopt menucomplete
> % echo <TAB until Zle/ comes up>
>        <^D to get listing of Zle/ (OK)>
>        <TAB to do menu selection in Zle/>
> % echo Zle/zsh: bus error (core dumped)  zsh -f

[That wasn't caused by the speedup patch.]

Oops. When stopping menu-completion we should invalidate the
current-match pointer, too, if another completion attempt is
imminent.

Bye
 Sven

Index: Src/Zle/compcore.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compcore.c,v
retrieving revision 1.30
diff -u -r1.30 compcore.c
--- Src/Zle/compcore.c	2000/06/07 08:39:57	1.30
+++ Src/Zle/compcore.c	2000/06/09 11:11:44
@@ -512,6 +512,7 @@
 	if ((ret = runhookdef(MENUSTARTHOOK, (void *) &cdat))) {
 	    dat[1] = 0;
 	    menucmp = menuacc = 0;
+	    minfo.cur = NULL;
 	    if (ret == 2) {
 		fixsuffix();
 		cs = 0;
Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.22
diff -u -r1.22 complist.c
--- Src/Zle/complist.c	2000/06/07 08:39:57	1.22
+++ Src/Zle/complist.c	2000/06/09 11:11:45
@@ -1778,6 +1778,7 @@
 	    s->origcs = origcs;
 	    s->origll = origll;
 	    menucmp = menuacc = hasoldlist = 0;
+	    minfo.cur = NULL;
 	    fixsuffix();
 	    validlist = 0;
 	    amatches = pmatches = lastmatches = NULL;

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de