Re: Unitialized memory reads again.

Re: Unitialized memory reads again.

[Sven Wischnowsky]

Felix Rosencrantz wrote:

> Sorry to report that I started seeing new uninitialized memory reads
> during completion.  Now at different location.
>         match_str      [compmatch.c:806]
>         match_str      [compmatch.c:598]
>         match_str      [compmatch.c:598]
>         addmatches     [compcore.c:1801]
>         bin_compadd    [complete.c:606]
>         ---------------------------------
>         match_str      [compmatch.c:806]
>         match_str      [compmatch.c:598]
>         addmatches     [compcore.c:1801]
>         bin_compadd    [complete.c:606]
> 
> Though these seem to be more difficult to trip over.

Before using the patch below, could you try if `setopt __listbeep__<TAB>'
shows the bad behaviour (probably adding more `_'s to the end)? If it
does, the patch below should fix it (of course, with uninitialized
memory reads it could be that this is the problem but it doesn't show
up, sigh).

> The recent changes to the trap code have fixed the memory leaks
> reported in 11766, and no new errors.

Good. I was about to ask.

> Sven, thanks for the stat optimizations to _path_files.  It seems faster.
> Plus, file completion works nicely with Clearcase now.  (Though... the
> additional change you were suggesting in workers/9631 for a "style that
> gives a pattern to match pathname components that should be accepted
> immediately" would make it work even better... :) )

I had forgotten about that... we'll see.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Unitialized memory reads again.

[Felix Rosencrantz]

Sorry to report that I started seeing new uninitialized memory reads
during completion.  Now at different location.
        match_str      [compmatch.c:806]
        match_str      [compmatch.c:598]
        match_str      [compmatch.c:598]
        addmatches     [compcore.c:1801]
        bin_compadd    [complete.c:606]
        ---------------------------------
        match_str      [compmatch.c:806]
        match_str      [compmatch.c:598]
        addmatches     [compcore.c:1801]
        bin_compadd    [complete.c:606]

Though these seem to be more difficult to trip over.

The recent changes to the trap code have fixed the memory leaks
reported in 11766, and no new errors.

Sven, thanks for the stat optimizations to _path_files.  It seems faster.
Plus, file completion works nicely with Clearcase now.  (Though... the
additional change you were suggesting in workers/9631 for a "style that
gives a pattern to match pathname components that should be accepted
immediately" would make it work even better... :) )

-FR.

__________________________________________________
Do You Yahoo!?
Yahoo! Photos -- now, 100 FREE prints!
http://photos.yahoo.com