zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: RE: undo does not work in menu-selection
Date: Mon, 19 Jun 2000 16:48:42 +0200 (MET DST)	[thread overview]
Message-ID: <200006191448.QAA00008@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Andrej Borsenkow"'s message of Mon, 19 Jun 2000 14:56:58 +0400


Andrej Borsenkow wrote:

> > Err? What should it undo? And keep in mind that undo has this
> > possibility to go up and resume completing in menu-selection.
> >
> > Hm, or make it leave selection when at the `top-level'?
> 
> This looks natural. And it is really confusing, when undo just does
> nothing at all.
> 
> > But you have noticed how ^G behaves in menu-selection, yes?
> >
> 
> Ehem ... sorry, yes. Still, it is better when a widget (undo in this
> case) has consistent behaviour. In this case, action is to start
> menu-selection - so "undone" action is to leave menu-selection?

I could convince myself... or does anyone object?


Bye
 Sven

Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.27
diff -u -r1.27 complist.c
--- Src/Zle/complist.c	2000/06/14 06:54:45	1.27
+++ Src/Zle/complist.c	2000/06/19 14:48:08
@@ -1852,7 +1852,7 @@
 	    int l;
 
 	    if (!u)
-		goto getk;
+		break;
 
 	    cs = 0;
 	    foredel(ll);

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


                 reply	other threads:[~2000-06-19 14:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200006191448.QAA00008@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).