zsh-workers
 help / color / mirror / code / Atom feed
From: Felix Rosencrantz <f_rosencrantz@yahoo.com>
To: zsh-workers <zsh-workers@sunsite.auc.dk>
Subject: Possible zle_tricky.c memory leak & history typo
Date: Sun, 25 Jun 2000 23:45:37 -0700 (PDT)	[thread overview]
Message-ID: <20000626064537.12022.qmail@web1303.mail.yahoo.com> (raw)

There are several typos in the latest changes to the history completers.
The last line of the completer looks like:
	(( $compstate[namtches] ))

I don't think the "$" sign is needed, (_history_complete_word, also has this
problem then.)  Also, the "am" need to be switched in "namtches".

I've been tight on time, otherwise I would send the patch or make the change
myself. (if no one fixes this, i'll fix it when i get time.)


Also, there was (and might still be) a memory leak in the version of
zle_tricky.c from June 9th.  Below is the stack trace where the memory is
allocated.  (The line numbers are from the june 10th version. Sorry not to use
the current version).  I think the bug might be at line 607, where s is not
freed before we return.
               zalloc         [mem.c:453]
               ztrdup         [mem.c:530]
               get_comp_string [zle_tricky.c:1595]
               docomplete     [zle_tricky.c:586]
               expandorcomplete [zle_tricky.c:282]


-FR

__________________________________________________
Do You Yahoo!?
Get Yahoo! Mail - Free email you can access from anywhere!
http://mail.yahoo.com/


             reply	other threads:[~2000-06-26  6:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-06-26  6:45 Felix Rosencrantz [this message]
2000-06-26  8:18 Sven Wischnowsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20000626064537.12022.qmail@web1303.mail.yahoo.com \
    --to=f_rosencrantz@yahoo.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).