zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Re: segfault with _rpm completion
Date: Mon, 26 Jun 2000 10:09:30 +0200 (MET DST)	[thread overview]
Message-ID: <200006260809.KAA18398@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Adam Spiers's message of Mon, 26 Jun 2000 02:37:32 +0100


Adam Spiers wrote:

> Latest cvs zsh dumps core after
> 
>   $ zsh -f
>   $ autoload compinit; compinit
>   $ rpm -qf /<TAB>

Missing allocation for the option-argument list. Ouch.

Bye
 Sven

Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.34
diff -u -r1.34 computil.c
--- Src/Zle/computil.c	2000/06/22 08:42:37	1.34
+++ Src/Zle/computil.c	2000/06/26 08:08:53
@@ -1349,6 +1349,8 @@
 		state.argend = argend;
 		doff = state.doff = 0;
 		state.singles = 1;
+		if (!state.oargs[state.curopt->num])
+		    state.oargs[state.curopt->num] = znewlinklist();
 		goto cont;
 	    } else {
 		state.curopt = NULL;
@@ -1422,6 +1424,9 @@
 
 	    if (sopts && nonempty(sopts))
 		state.curopt = (Caopt) uremnode(sopts, firstnode(sopts));
+
+	    if (!state.oargs[state.curopt->num])
+		state.oargs[state.curopt->num] = znewlinklist();
 
 	    ddef = state.def = state.curopt->args;
 	    dopt = state.curopt;

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


                 reply	other threads:[~2000-06-26  8:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200006260809.KAA18398@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).