From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Bug in ${(z)...} lexing, or what?
Date: Wed, 12 Jul 2000 12:29:43 +0200 (MET DST) [thread overview]
Message-ID: <200007121029.MAA21938@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Wed, 12 Jul 2000 08:25:15 +0000
Bart Schaefer wrote:
> This has me baffled.
>
> Consider the following innocuous-looking function:
>
> widget() {
> zle up-history
> lastcmd=( ${(z)BUFFER} )
> zle down-history
> }
>
> Now try this:
>
> zagzig% zle -N widget
> zagzig% bindkey '\e=' widget
> zagzig% ( setopt extendedglob ; [[ 'foo[x]=y' = (#i)[[:alpha:]][][[:alnum:]]#=* ]] )
> zagzig% echo $lastcmd
> ( setopt extendedglob ; [[ 'foo[x]=y' = ( ;
> zagzig%
>
> What happened to everything after the '#' in '(#i)' ?? And where did that
> extra semicolon come from?
>
> The really strange thing is that this happens only in ZLE widgets, and only
> when there's a command separator (semi, amper, pipe, etc.) somewhere to the
> left of the [[ ]] expression. If I try the same thing outside of ZLE, it
> works perfectly; if I try a bare glob (not in [[ ... ]]) it also works.
You have interactive_comments set, right?
This should fix that (I haven't looked close enough to find out when
it did that and when it didn't).
There is still something fishy, though. A string like `ls (#i)foo' is
broken into `ls' and `(#i)foo', but `[[ (#i)foo ]]' is broken into
`[[', `(', `#i', `)', ... I haven't found out where and why this
happens yet.
Bye
Sven
Index: Src/hist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/hist.c,v
retrieving revision 1.8
diff -u -r1.8 hist.c
--- Src/hist.c 2000/05/30 14:08:48 1.8
+++ Src/hist.c 2000/07/12 10:29:12
@@ -2058,15 +2058,15 @@
bufferwords(LinkList list, char *buf, int *index)
{
int num = 0, cur = -1, got = 0, ne = noerrs, ocs = cs;
- int owb = wb, owe = we, oadx = addedx, ozp = zleparse;
+ int owb = wb, owe = we, oadx = addedx, ozp = zleparse, oexp = expanding;
char *p;
if (!list)
list = newlinklist();
- zleparse = 1;
+ zleparse = 3;
addedx = 0;
- noerrs = 1;
+ noerrs = expanding = 1;
lexsave();
if (buf) {
int l = strlen(buf);
@@ -2133,6 +2133,7 @@
inpop();
errflag = 0;
zleparse = ozp;
+ expanding = oexp;
noerrs = ne;
lexrestore();
cs = ocs;
Index: Src/lex.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/lex.c,v
retrieving revision 1.8
diff -u -r1.8 lex.c
--- Src/lex.c 2000/06/06 08:35:54 1.8
+++ Src/lex.c 2000/07/12 10:29:12
@@ -673,7 +673,7 @@
/* chars in initial position in word */
if (c == hashchar &&
- (isset(INTERACTIVECOMMENTS) ||
+ ((zleparse != 3 && isset(INTERACTIVECOMMENTS)) ||
(!zleparse && !expanding &&
(!interact || unset(SHINSTDIN) || strin)))) {
/* History is handled here to prevent extra *
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-07-12 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-12 10:29 Sven Wischnowsky [this message]
2000-07-12 10:40 ` Peter Stephenson
2000-07-12 15:14 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-07-12 10:47 Sven Wischnowsky
2000-07-12 11:11 ` Peter Stephenson
2000-07-12 16:57 ` Peter Stephenson
2000-07-12 18:41 ` Bart Schaefer
2000-07-12 8:25 Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200007121029.MAA21938@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).