Re: PATCH: Re: cvs completion messy on dangling slink

Re: PATCH: Re: cvs completion messy on dangling slink

[Sven Wischnowsky]

Bart Schaefer wrote:

> In the very general case, though, I still lament that there's no good way
> to capture this kind of error output and present it via _message or some
> other completion-friendly mechanism.

Yes. Any ideas for how to do that?

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Capturing completion stderr

[Bart Schaefer]

On Jul 21,  9:18am, Sven Wischnowsky wrote:
} Subject: Re: PATCH: Re: cvs completion messy on dangling slink
}
} Bart Schaefer wrote:
} 
} > In the very general case, though, I still lament that there's no good way
} > to capture this kind of error output and present it via _message or some
} > other completion-friendly mechanism.
} 
} Yes. Any ideas for how to do that?

We'd have to use C code in ZLE to redirect stderr somewhere, at the same
places where it currently closes and restores stdin.  Further, we'd have
to figure out some kind of special handling for xtrace output in order
for _complete_debug to continue to be useful.

As to where stderr is redirected: The only sensible place is a temp file,
which is then checked for nonzero size at the end of the completion, and
displayed if so.  The shell can't try to capture the output directly, as
that could lead to deadlock.  As I said before, though, I dislike adding
the overhead of creating and then either truncating or unlinking a file
on every completion, when in most cases it won't be useful.

So probably the right thing is just to continue to be careful about the
stderr of commands within the individual functions, and perhaps document
somewhere that this is necessary.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

PATCH: Re: cvs completion messy on dangling slink

[Bart Schaefer]

On Jul 20, 11:32am, Peter Whaite wrote:
}
} _cvs_modified_entries:stat:8: .#fuji-2.patch: no such file or directory

This should take care of it.

In the very general case, though, I still lament that there's no good way
to capture this kind of error output and present it via _message or some
other completion-friendly mechanism.

Index: Completion/User/_cvs
===================================================================
@@ -748,7 +748,7 @@
     linedir="$match[1]"
     realdir=${(e)~linedir}
     [[ -f "$realdir"CVS/Entries ]] &&
-    [[ -n ${pat::="${(@j:|:)${(@)${(@)${(@)${(@)${(@)${(@M)${(@f)"$(<"$realdir"CVS/Entries)"}:#/*}#/}/\\/[^\\/]#\\///}%/[^/]#/[^/]#}:#${(j:|:)~${${${${(f)"$(LC_ALL=C builtin stat -gn +mtime -F '%a %b %e %T %Y' ${realdir}*(D))"}##*/}/ //}//(#m)[][*?()<|^~#\\]/\\$MATCH}}}%%/*}//(#m)[][*?()<|^~#\\]/\\$MATCH}"} ]] &&
+    [[ -n ${pat::="${(@j:|:)${(@)${(@)${(@)${(@)${(@)${(@M)${(@f)"$(<"$realdir"CVS/Entries)"}:#/*}#/}/\\/[^\\/]#\\///}%/[^/]#/[^/]#}:#${(j:|:)~${${${${(f)"$(LC_ALL=C builtin stat -gn +mtime -F '%a %b %e %T %Y' ${realdir}*(D) 2>/dev/null)"}##*/}/ //}//(#m)[][*?()<|^~#\\]/\\$MATCH}}}%%/*}//(#m)[][*?()<|^~#\\]/\\$MATCH}"} ]] &&
     _wanted files expl file _path_files -g "$pat"
   else
     _cvs_existing_entries

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net