zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Re: 3.1.9-dev-6 completion problem: `a | b`
Date: Wed, 4 Oct 2000 15:52:09 +0200 (MET DST)	[thread overview]
Message-ID: <200010041352.PAA10341@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "E. Jay Berkenbilt"'s message of Wed, 13 Sep 2000 13:06:51 -0400


E. Jay Berkenbilt wrote:

> If I say any of the following:
> 
> a | TAB
> `TAB
> a; TAB
> `a; TAB
> 
> I get a list of commands.  However, if I say
> 
> `a | TAB
> 
> I get a list of files.  In fact, even if I say
> 
> `a | junkTAB
> 
> I get a list of files.  I haven't studied the code enough to know what
> the problem is.  Changing ` to $( in all above cases does not change
> the behavior.

Ah, my favorite pastime: fiddling with get_comp_string(). Urgh.

It appears that this was a bad interaction with the code for control
structures. When reaching the word the cursor is on, it tested if it
had reached that before and if it had, it stopped looking
further. This was wrong when it was working on a `...` or $(...) string.

Bye
 Sven

Index: Src/Zle/zle_tricky.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_tricky.c,v
retrieving revision 1.20
diff -u -r1.20 zle_tricky.c
--- Src/Zle/zle_tricky.c	2000/08/29 08:21:00	1.20
+++ Src/Zle/zle_tricky.c	2000/10/04 13:51:47
@@ -1158,6 +1158,7 @@
 		line[ll + addedx] = '\0';
 	    }
 	    lexrestore();
+	    tt = NULL;
 	    goto start;
 	}
     }

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


                 reply	other threads:[~2000-10-04 13:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200010041352.PAA10341@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).