From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: RE: Trivial patches for FreeBSD
Date: Thu, 5 Oct 2000 15:48:52 +0200 (MET DST) [thread overview]
Message-ID: <200010051348.PAA13722@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Thu, 7 Sep 2000 14:40:38 +0000
Bart Schaefer wrote:
> On Sep 7, 10:38am, Sven Wischnowsky wrote:
> }
> } Andrej Borsenkow wrote:
> }
> } > compadd "$@" - /boot/kernel/*.ko(N:t) /modules/*.ko(N:t) && ret=0
> }
> } That sounds reasonable. I've changed in some other places, too (anyone
> } who uses _mailboxes please check my work there).
>
> Looks OK, but:
>
> Is there EVER a case where we want the completion system to fail with a
> "no match" error, or to return a glob pattern instead of an actual file
> name?
>
> Maybe _main_complete should setopt nullglob nocshnullglob and have done
> with it.
Interestingly, in _main_complete:19 we see:
setopt localoptions nullglob ...
And it seems to have been there for quite some time. Maybe we (ok, I)
got confused because in some places we use the foo(N) trick to turn a
normal string into a pattern to avoid having to explicitly test for
the existence of files searched.
But since cshnullglob overrides nullglob, we should probably unset
that in _main_complete, as Bart suggests...
Bye
Sven
Index: Completion/Core/_main_complete
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_main_complete,v
retrieving revision 1.40
diff -u -r1.40 _main_complete
--- Completion/Core/_main_complete 2000/08/03 13:35:44 1.40
+++ Completion/Core/_main_complete 2000/10/05 13:30:51
@@ -16,8 +16,8 @@
# which makes the output of setopt and unsetopt reflect a different
# state than the global one for which you are completing.
-setopt localoptions nullglob rcexpandparam extendedglob noshglob
-unsetopt markdirs globsubst shwordsplit nounset ksharrays
+setopt localoptions nullglob rcexpandparam extendedglob noshglob \
+ nomarkdirs noglobsubst noshwordsplit unset noksharrays nocshnullglob
exec </dev/null # ZLE closes stdin, which can cause errors
# Failed returns from this code are not real errors
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-10-05 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-05 13:48 Sven Wischnowsky [this message]
2000-10-05 17:08 ` Bart Schaefer
2000-10-05 17:23 ` Andrej Borsenkow
2000-10-06 4:25 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-09-07 8:38 Sven Wischnowsky
2000-09-07 14:40 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200010051348.PAA13722@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).