From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: _expand, _expand_word, and their doc
Date: Mon, 9 Oct 2000 13:49:52 +0200 (MET DST) [thread overview]
Message-ID: <200010091149.NAA18628@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Sun, 8 Oct 2000 19:35:38 +0000
As I said, I didn't find much time at the weekend, but I've been
playing and thinking a bit.
Bart Schaefer wrote:
> ...
>
> Hm. I don't have any overwhelming disagreement with that; the issue is
> not so much that _expand_word should handle it, as that _expand should
> not -- Andrej is clearly correct that _match is what actually does the
> most-correct thing in terms of generating the possible completions, so
> the question is how to get them all (offered to be) inserted at once.
As you said below, it isn't really _match either. It's any completer
that generates completions. And after re-thinking, I'm not so sure
about adding all completions as a single match anymore either. What
Andrej suggested (using an old list) really seems most useful for me
currently (getting a list, looking at it and then deciding to insert
them all -- less keystrokes than menuing to the all-completions entry).
(And the reason is not only that, trying a simple implementation, I
had some small problems getting it to work -- problems with the
prefix/suffic handling and when completing inside braces. That could
probably be solved.)
And the fact that _expand can offer both doesn't worry me very much
either, since there we are expanding a pattern the shell would expand
there anyway. It only looks slightly weird if one only things about
the combination of _match and inserting all completions.
> ...
>
> I'd say we should use a new completer which has to appear very late in
> the completer list, and which modifies the handling of the completions
> that are generated before it is called. As you suggest here:
I agree that this ordering looks sensible, but only unless one wants
it to re-use an old list. Then it should be at the very beginning,
which is almost an argument in favour of code like the one in
_expand. Or to put the whole thing into it's own completer that can
use an old list or builds a new one, calling the other completers
directly.
Hm, that would also be the easiest solution and could already be
implemented without having to change the C-code.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-10-09 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-09 11:49 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-10-06 8:14 Sven Wischnowsky
2000-10-06 12:34 ` Andrej Borsenkow
2000-10-06 13:00 ` Sven Wischnowsky
2000-10-08 19:35 ` Bart Schaefer
2000-10-05 8:13 Sven Wischnowsky
2000-10-05 15:21 ` Bart Schaefer
2000-10-05 15:34 ` Andrej Borsenkow
2000-10-05 17:11 ` Bart Schaefer
2000-09-20 17:57 Bart Schaefer
2000-09-21 5:07 ` Bart Schaefer
2000-09-21 6:33 ` Andrej Borsenkow
2000-09-21 14:37 ` Bart Schaefer
2000-09-21 14:59 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200010091149.NAA18628@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).