From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
Date: Mon, 23 Oct 2000 10:18:07 +0200 (MET DST) [thread overview]
Message-ID: <200010230818.KAA14207@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Andrej Borsenkow"'s message of Mon, 23 Oct 2000 12:15:22 +0400
Andrej Borsenkow wrote:
> > + errno == EWOULDBLOCK
>
> Not exactly relevant, but assignment to errno is a bad style. It may well be a
> function (or some non-lvalue entity), espicially in case of threads support.
> Also, I was really surprised recently to hear, that C9X and ISO C++ _require_
> errno to be a macro.
>
> There are probably many other places where errno is assigned to, of course.
> But if we can avoid it - let's do it.
That's a comparison, not an assignment.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-10-23 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-23 8:18 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-10-23 7:59 Sven Wischnowsky
2000-10-23 8:15 ` OT: assignment to errno " Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200010230818.KAA14207@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).